<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 5/9/13 1:42 AM, John Cuthbertson
wrote:<br>
</div>
<blockquote cite="mid:518AE2E5.2040204@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
Hi Bengt,<br>
<br>
Thanks for looking at the changes. Reply inline....<br>
<br>
<div class="moz-cite-prefix">On 5/8/2013 9:18 AM, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:518A7AEA.6090804@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
</div>
John, I just noticed one thing that I find a bit odd. The
G1CollectorPolicy::print_detailed_heap_transition() method is
only called from
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
G1CollectedHeap::do_collection(), so it really doesn't have to
take the full parameter. It could always print the metaspace
information, right?<br>
</blockquote>
<br>
There are two calls to
G1CollectorPolicy::print_detailed_heap_transition(). The other is
from G1CollectedHeap::log_gc_footer():<br>
</blockquote>
<br>
Ah! I missed that since I was only looking through the webrev (on my
phone) and there is a default value for the full parameter, so there
was only one place where print_detailed_heap_transition() had been
updated. Sorry for the confusion.<br>
<br>
Bengt<br>
<br>
<br>
<blockquote cite="mid:518AE2E5.2040204@oracle.com" type="cite"> <br>
<blockquote type="cite">void G1CollectedHeap::log_gc_footer(double
pause_time_sec) {<br>
if (!G1Log::fine()) {<br>
return;<br>
}<br>
<br>
if (G1Log::finer()) {<br>
if (evacuation_failed()) {<br>
gclog_or_tty->print(" (to-space exhausted)");<br>
}<br>
gclog_or_tty->print_cr(", %3.7f secs]", pause_time_sec);<br>
g1_policy()->phase_times()->note_gc_end();<br>
g1_policy()->phase_times()->print(pause_time_sec);<br>
g1_policy()->print_detailed_heap_transition();<br>
} else {<br>
if (evacuation_failed()) {<br>
gclog_or_tty->print("--");<br>
}<br>
g1_policy()->print_heap_transition();<br>
gclog_or_tty->print_cr(", %3.7f secs]", pause_time_sec);<br>
}<br>
gclog_or_tty->flush();<br>
}<br>
</blockquote>
<br>
and comes at the end of an evacuation pause. So I think we need
the parameter - unless we decide to include in the output for each
GC.<br>
<br>
JohnC<br>
</blockquote>
<br>
</body>
</html>