<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Andreas,<br>
<br>
On 5/14/13 11:21 AM, Andreas Eriksson wrote:<br>
</div>
<blockquote cite="mid:51920225.5000107@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi,<br>
<br>
I changed the date and time stamping calls to use the guarded
convenience variants.<br>
Both of these calls suffixes a ": " automatically. See
share/vm/utilities/ostream.hpp line 99 and 105.<br>
</div>
</blockquote>
<br>
Right. Sorry I missed that!<br>
<br>
The change looks good.<br>
<br>
Bengt<br>
<br>
<blockquote cite="mid:51920225.5000107@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
It currently looks like this:<br>
% ./hsx24_hotspot-build/bin/java -Xmx2m -verbose:gc
-XX:+PrintGCTimeStamps -XX:+PrintGCDateStamps HumongousAlloc<br>
2013-05-14T11:17:28.340+0200: 0.050: [GC 1896K->421K(3136K),
0.0011640 secs]<br>
2013-05-14T11:17:28.341+0200: 0.051: [GC 2329K->437K(3136K),
0.0029750 secs]<br>
<br>
This is how it looked before as well:<br>
% ~/builds/linux-amd64/7u25/bin/java -Xmx2m -verbose:gc
-XX:+PrintGCTimeStamps -XX:+PrintGCDateStamps HumongousAlloc<br>
2013-05-14T11:17:31.603+0200: 0.059: [GC 2025K->417K(3136K),
0.0008100 secs]<br>
2013-05-14T11:17:31.605+0200: 0.060: [GC 2325K->417K(3136K),
0.0015140 secs]<br>
<br>
Thanks for looking at this.<br>
<br>
/Andreas<br>
<br>
On 2013-05-14 08:23, Bengt Rutisson wrote:<br>
</div>
<blockquote cite="mid:5191D845.60402@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Hi Andreas,<br>
<br>
Looks good.<br>
<br>
One question regarding the change in GCTraceTime:<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eaeriksso/7176220/webrev.00/src/share/vm/gc_implementation/shared/gcTraceTime.cpp.udiff.html">http://cr.openjdk.java.net/~aeriksso/7176220/webrev.00/src/share/vm/gc_implementation/shared/gcTraceTime.cpp.udiff.html</a><br>
<br>
It looks to me like we are missing a ": " in the new version.
Maybe it is ok to loose this character in the log format, but
a safer change may be:<br>
<br>
if (PrintGCTimeStamps || PrintGCDateStamps) {<br>
gclog_or_tty->date_stamp(PrintGCDateStamps);<br>
gclog_or_tty->stamp(PrintGCTimeStamps);<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
gclog_or_tty->print(": ");<br>
}<br>
<br>
This actually still changes the ": " behavior since since you
didn't use to get a ": " if you only had PrintGCDateStamps
enabled. But I think this is a more expected behavior.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
On 5/13/13 6:01 PM, Andreas Eriksson wrote:<br>
</div>
<blockquote cite="mid:51910E66.9050000@oracle.com" type="cite">Hi
all, <br>
<br>
Please take a look at my changes for bug 7176220. <br>
The problem is that CMS sometimes misses datestamps for time
trace printouts. <br>
<br>
The proposed fix is to move the datestamp print logic into the
class that handles time trace printouts, GCTraceTime. <br>
This would make it consistent with timestamps, which are
already printed from there. <br>
<br>
Bugs.sun: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://bugs.sun.com/view_bug.do?bug_id=7176220">http://bugs.sun.com/view_bug.do?bug_id=7176220</a>
<br>
<br>
JIRA: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://jbs.oracle.com/bugs/browse/JDK-7176220">https://jbs.oracle.com/bugs/browse/JDK-7176220</a>
<br>
<br>
Webrev: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eaeriksso/7176220/webrev.00/">http://cr.openjdk.java.net/~aeriksso/7176220/webrev.00/</a>
<br>
<br>
Testing: <br>
jprt, jtreg <br>
<br>
Thanks, <br>
Andreas <br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>