<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Jesper,<br>
<br>
I agree with John, the line break in psScavenge.cpp looks
intentional and should probably not be changed.<br>
<br>
Also, please use gclog_or_tty->print_cr() in
psAdaptiveSizePolicy.cpp rather than adding extra calls to
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
gclog_or_tty->cr();<br>
<br>
Bengt<br>
<br>
On 6/6/13 8:46 PM, John Cuthbertson wrote:<br>
</div>
<blockquote cite="mid:51B0D916.9030006@oracle.com" type="cite">Hi
Jesper,
<br>
<br>
The change is psAdaptiveSizePolicy.cpp looks good.
<br>
<br>
I don't, however, think you should remove the line break in
psScavenge.cpp. I _that_ that line break is meant to be there. The
output beginning with "avg_survived_padded_avg" is slightly
indented. Compare the other places where "AdaptiveSizeStart" is
printed in psMarkSweep.cpp and psParallelCompact.cpp. Leaving line
break in will make the output:
<br>
<br>
AdaptiveSizeStart: 23.548 collection: 67
<br>
avg_survived_padded_avg: 728176.250000
avg_promoted_padded_avg: 223962144.000000
avg_pretenured_padded_avg: 187235776.000000 tenuring_thresh: 14
target_size: 1048576
<br>
<br>
JohnC
<br>
<br>
On 6/5/2013 2:50 PM, Jesper Wilhelmsson wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
Can I have a couple of reviews for this really minor fix?
<br>
<br>
8015903: Fomat issue with -XX:+PRINTADAPTIVESIZEPOLICY on JDK8
<br>
<br>
A missing line break in the adaptive size verbose logging has
been added.
<br>
<br>
When looking at this I also found that an existing line break
caused a slightly ugly verbose output when breaking a line
causing a second line without a identifier at the beginning. I
removed that line break as well in this change.
<br>
<br>
<br>
webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jwilhelm/8015903/hotspot-webrev/">http://cr.openjdk.java.net/~jwilhelm/8015903/hotspot-webrev/</a>
<br>
<br>
<br>
<br>
Output before:
<br>
<br>
AdaptiveSizePolicy::update_averages: survived: 163840
promoted: 0 overflow: falseAdaptiveSizeStart: 23.548
collection: 67
<br>
avg_survived_padded_avg: 728176.250000
avg_promoted_padded_avg: 223962144.000000
avg_pretenured_padded_avg: 187235776.000000 tenuring_thresh: 14
target_size: 1048576
<br>
<br>
<br>
Output after:
<br>
<br>
AdaptiveSizePolicy::update_averages: survived: 163840
promoted: 0 overflow: false
<br>
AdaptiveSizeStart: 23.548 collection: 67
avg_survived_padded_avg: 728176.250000 avg_promoted_padded_avg:
223962144.000000 avg_pretenured_padded_avg: 187235776.000000
tenuring_thresh: 14 target_size: 1048576
<br>
<br>
<br>
Thanks,
<br>
/Jesper
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>