<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 6/7/13 3:20 PM, Hiroshi Yamauchi
wrote:<br>
</div>
<blockquote
cite="mid:CAASM7NJ=RWdPcGK32aA+xcL32fLSufUboGzJBXu2eZQyUCb-hg@mail.gmail.com"
type="cite">
<div dir="ltr">Here's an update version of the first patch based
on what's been discussed so far:
<div><br>
</div>
<div> <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ehiroshi/webrevs/cmsparinitmark/webrev.02/">http://cr.openjdk.java.net/~hiroshi/webrevs/cmsparinitmark/webrev.02/</a><br>
</div>
<div><br>
</div>
<div>I'll catch up with the comments on the other patch later.<br>
</div>
</div>
</blockquote>
Changes look good.<br>
<br>
Thanks.<br>
<br>
Jon<br>
<blockquote
cite="mid:CAASM7NJ=RWdPcGK32aA+xcL32fLSufUboGzJBXu2eZQyUCb-hg@mail.gmail.com"
type="cite">
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Fri, Jun 7, 2013 at 1:12 PM, Jon
Masamitsu <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:jon.masamitsu@oracle.com" target="_blank">jon.masamitsu@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">I've
created the CR 8016184<br>
<br>
Consolidate common code between MarkRefsIntoClosure and
Par_MarkRefsIntoClosure<br>
<br>
Hiroshi,<br>
<br>
The renaming of Par_MarkRefsIntoClosure to
ParMarkRefsIntoClosure can<br>
wait (unless you've already done it). As you've seen the
use of<br>
Par_<class_name> is wide spread in CMS and should be
fixed<br>
comprehensively in one changeset.<span class="HOEnZb"><font
color="#888888"><br>
<br>
Jon</font></span>
<div class="HOEnZb">
<div class="h5"><br>
<br>
<br>
On 6/7/2013 11:39 AM, Hiroshi Yamauchi wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Thomas,<br>
<br>
Thanks for your comments. I'll be catching up with
them.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<blockquote class="gmail_quote" style="margin:0 0
0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">
<blockquote class="gmail_quote" style="margin:0
0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">
- in cmsOopClosures.hpp,
MarkRefsIntoClosure and the new<br>
Par_MarkRefsIntoClosure could be refactored
slightly as they have<br>
exactly the same member variables. Not sure
how this situation is<br>
handled in other code though, and what others
(Jon) think.<br>
<br>
</blockquote>
Thomas,<br>
<br>
If you don't mind I'd like to keep this
changeset to a minimum so<br>
not do any additional refactoring. That's a
good suggestion but<br>
since this is the first sizable contribution I'm
sponsoring, simpler<br>
is better for me.<br>
<br>
</blockquote>
Okay. It would be a tiny additional change though,
which has only been<br>
enabled by the addition of the
Par_MarkRefsIntoClosure, and of course<br>
depends on whether the old serial initial marking
code is kept.<br>
<br>
</blockquote>
Thanks.<br>
<br>
<br>
</blockquote>
Regarding whether to refactor MarkRefsIntoClosure and<br>
Par_MarkRefsIntoClosure, it's a valid point. I assume
you are referring to<br>
factoring out the common parts into a common super
class.<br>
<br>
I don't have a strong opinion. Looking at the
exchanges, I'm interpreting<br>
it as "let's not do it right now." Let me know if it's
not the case.<br>
<br>
</blockquote>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>