<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
new webrev: "Frame" seems to be the best way to review it.<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~tamao/8010506/webrev.02/">http://cr.openjdk.java.net/~tamao/8010506/webrev.02/</a><br>
<br>
Suggestion are taken mostly from Thomas. <br>
<br>
Thanks.<br>
Tao<br>
<br>
On 5/14/13 2:46 PM, Jon Masamitsu wrote:
<blockquote cite="mid:5192B0BE.1020809@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">On 4/30/13 4:58 PM, Tao Mao wrote:<br>
</div>
<blockquote cite="mid:51805AC1.9040802@oracle.com" type="cite">new
webrev <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Etamao/8010506/webrev.01/">http://cr.openjdk.java.net/~tamao/8010506/webrev.01/</a>
<br>
<br>
It needs reviews. <br>
</blockquote>
<br>
Tao,<br>
<br>
Changes you made look good. I did not see a list of the<br>
suggested changes in the CR <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://jbs.oracle.com/bugs/browse/JDK-8010506">https://jbs.oracle.com/bugs/browse/JDK-8010506</a><br>
<br>
so don't have any comment about what you decided not<br>
to change.<br>
<br>
<blockquote cite="mid:51805AC1.9040802@oracle.com" type="cite"> <br>
Changeset: <br>
Thank you for the thorough report of all these typos/errros,
Thomas. <br>
<br>
I changed most places according to your suggestions (for the
rest few, I did not change because it may slightly change the
meaning of the definition). Also, I went through the file to
change some similar common errors that occurred. <br>
<br>
Several issues: <br>
<br>
(1) parallel gc should be lower case or upper case? <br>
As I know and, perhaps, someone told me, the term "parallel gc"
sometimes refers to a more generic terminology rather than
ParallelGC or ParallelOldGC, if it doesn't imply these two.
Basically, any GC algorithms that can be parallelized could fall
into this category. Right now, we probably refer "parallel gc"
to ParallelGC or ParallelOldGC. But, we reserve the right to
change it to something else. That's why "fuzziness" exists here.
I guess the same way to deal with "concurrent gc". So, I didn't
make these words upper cased. <br>
<br>
(2) Identification: <br>
The general rule is to follow the example (product()'s
identification). The whole file checked and space adjusted
accordingly. <br>
<br>
(3) Line breaks <br>
A space should be provided at the line breaks if multiple lines
is needed. Some lines that are slightly longer than normal
length is kept untouched as long as they read well. <br>
<br>
*(4) Why does the VM option hashCode have lower case initial? <br>
The direct answer is "I don't know". (But it is understandable
that hashCode is "legacy" such that it has it own style) Anyone
knows the answer? <br>
</blockquote>
<br>
I don't know for sure either but might be because of the Java code<br>
<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<pre>public int <b>hashCode</b>()
Jon
</pre>
<br>
<blockquote cite="mid:51805AC1.9040802@oracle.com" type="cite"> <br>
Thanks. <br>
Tao <br>
<br>
On 3/21/13 3:09 PM, Tao Mao wrote: <br>
<blockquote type="cite">8010506 Typos and errors in gc-related
flags in globals.hpp <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://jbs.oracle.com/bugs/browse/JDK-8010506">https://jbs.oracle.com/bugs/browse/JDK-8010506</a>
<br>
<br>
webrev: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Etamao/8010506/webrev.00/">http://cr.openjdk.java.net/~tamao/8010506/webrev.00/</a>
<br>
<br>
Changeset: <br>
NewRatio should defined as <br>
product(uintx, NewRatio,
2, \ <br>
"Ratio of old/new generation
sizes") \ <br>
instead of <br>
product(uintx, NewRatio,
2, \ <br>
"Ratio of new/old generation
sizes") \ <br>
<br>
PLUS other typos found by Jesper. <br>
</blockquote>
</blockquote>
<br>
</blockquote>
</body>
</html>