<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Hi everyone,<br>
<br>
Could I have a couple of reviews for this very small change?<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/8021879/webrev.00/">http://cr.openjdk.java.net/~brutisso/8021879/webrev.00/</a><br>
<br>
Background:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
The G1HeapRegionSize flag is not updated with the actual value of
the region size. This makes it impossible to figure out the heap
region size using PrintFlagsFinal:
<br>
<br>
$ java -XX:+UseG1GC -XX:+PrintFlagsFinal -version | grep
G1HeapRegionSize
<br>
uintx G1HeapRegionSize = 0 {product} <br>
<br>
Or when setting it to the wrong value (this will actually use a
region size of 8m):
<br>
<br>
$ java -XX:+UseG1GC -XX:G1HeapRegionSize=11m -XX:+PrintFlagsFinal
-version | grep G1HeapRegionSize
<br>
uintx G1HeapRegionSize := 11534336 {product} <br>
<br>
<br>
With the proposed patch I get this output:<br>
<br>
$ java -XX:+UseG1GC -XX:+PrintFlagsFinal -version | grep
G1HeapRegionSize<br>
uintx G1HeapRegionSize :=
1048576 {product} <br>
<br>
and:<br>
<br>
$ java -XX:+UseG1GC -XX:G1HeapRegionSize=11m -XX:+PrintFlagsFinal
-version | grep G1HeapRegionSize<br>
uintx G1HeapRegionSize :=
8388608 {product} <br>
<br>
<br>
Here are also some interesting scenarios that are visible with my
suggested patch:<br>
<br>
$ java -XX:+UseG1GC -Xmx64g -XX:+PrintFlagsFinal -version | grep
G1HeapRegionSize<br>
uintx G1HeapRegionSize :=
1048576 {product} <br>
<br>
$ java -XX:+UseG1GC -Xms64g -Xmx64g -XX:+PrintFlagsFinal -version |
grep G1HeapRegionSize<br>
uintx G1HeapRegionSize :=
33554432 {product} <br>
<br>
Thanks,<br>
Bengt<br>
</body>
</html>