<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Bengt,<br>
<br>
Is using
<meta charset="utf-8">
!FLAG_IS_DEFAULT(DefaultMaxRAMFraction) to trigger the warning a
little inaccurate compared to FLAG_IS_CMDLINE() in this case, given
that we have the possibility of FLAG_IS_ERGO()? <br>
<br>
Otherwise, it looks good.<br>
<br>
Thanks.<br>
Tao<br>
<br>
On 7/31/13 11:28 AM, Bengt Rutisson wrote:
<blockquote cite="mid:51F95769.4090708@oracle.com" type="cite">
<br>
Hi Vladimir,
<br>
<br>
Thanks for looking at this!
<br>
<br>
On 7/31/13 6:06 PM, Vladimir Kozlov wrote:
<br>
<blockquote type="cite">Bengt,
<br>
<br>
You have special method in arguments.cpp
check_deprecated_gc_flags(). Why not use it?
<br>
</blockquote>
<br>
I'm fine with that. I wasn't really sure whether to consider
DefaultMaxRAMFraction a GC flag or not. Anyway, either way is fine
with me. Here is a webrev with the warning message in
check_deprecated_gc_flags() instead:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/8021967/webrev.01/">http://cr.openjdk.java.net/~brutisso/8021967/webrev.01/</a>
<br>
<br>
Jon and Thomas, what do you prefer?
<br>
<br>
Thanks,
<br>
Bengt
<br>
<br>
<blockquote type="cite">
<br>
Thanks,
<br>
Vladimir
<br>
<br>
On 7/31/13 6:34 AM, Bengt Rutisson wrote:
<br>
<blockquote type="cite">
<br>
Hi all,
<br>
<br>
Could I have a couple of reviews for this small fix?
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/8021967/webrev.00/">http://cr.openjdk.java.net/~brutisso/8021967/webrev.00/</a>
<br>
<br>
For JDK8 we need to print a warning message when
DefaultMaxRAMFraction is used on the command line. This is to
allow us
<br>
to remove it for JDK9. The flag was superseded by
MaxRAMFraction in 2009 for the JDK6u18 release.
<br>
<br>
Thanks,
<br>
Bengt
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</body>
</html>