<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Jon,<br>
<br>
Thanks for doing this cleanup! I think it is really nice to get
this done!<br>
<br>
It is a bit hard to review this kind of refactoring, but as far as
I can tell it looks good. There might be more things that can
move, but I think this is a good start. I think the
concurrentMarkSweepHelper.hpp file indicates that we have some
more cleanups to do. But let's leave that for later.<br>
<br>
One minor nit. In cmsConcMarkTask.hpp you have the forward
declaration of
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
class CMSCollector on line 65. I'm more used to seeing the forward
declarations collected together at the top of the file.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<br>
On 8/9/13 7:39 PM, Jon Masamitsu wrote:<br>
</div>
<blockquote cite="mid:52052935.9010404@oracle.com" type="cite">8022725:Refactor
code in concurrentMarkSweepGeneration.cpp
<br>
<br>
concurrentMarkSweepGeneration.cpp is a rather large file and
should be refactored (split into multiple
<br>
files) for easier maintenance.
<br>
<br>
There are no intended semantic changes. Only reorganization and
moving of code.
<br>
<br>
I've been investigating some issues with compiler optimizations on
this file and the refactoring will make that doable.
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jmasa/8022725/webrev.00/">http://cr.openjdk.java.net/~jmasa/8022725/webrev.00/</a>
<br>
</blockquote>
<br>
</body>
</html>