<div dir="ltr"><div><div><div><div><div><div><div><br></div>Hi Yumin --<br><br></div>Somewhat orthogonal to the discussion at hand, and certainly not a code review/discussion (so i<br>apologize for injecting this into $SUBJ) but I wanted to say that log rotation is definitely a useful capability in the field.<br>
</div><br></div>Have you folks perhaps considered two possible enhancements:<br></div>(1) rotate logs at a frequency and time specified. (For example, on a daily, weekly or monthly basis.)<br></div>(2) rotate logs asynchronously upon request. (say via a suitable bean.)<br>
<br></div><div>If (1) can be simulated by existing means I am all ears.<br><br></div><div>thanks!<br></div>-- ramki<br><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 15, 2013 at 8:35 AM, Yumin Qi <span dir="ltr"><<a href="mailto:yumin.qi@oracle.com" target="_blank">yumin.qi@oracle.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Hi, <br>
<br>
Can I have your review for this small changes?<br>
<a href="http://cr.openjdk.java.net/%7Eminqi/7164841/webrev00/" target="_blank">http://cr.openjdk.java.net/~minqi/7164841/webrev00/</a><br>
<br>
This is for a enhancement to add head/tail message to the logging
files to assist reading GC output.<br>
1. modified prompt message if invalid arguments used for log
rotating;<br>
2. add time and file name message to log file head/tail.<br>
3. for easily identify which log file is current, use file name
like <filename>.n.current, after it reaches maximum size,
rename it to <filename>.n<br>
On Windows, there is no F_OK (existing test) definition,
F_OK is defined as "0" and for _access of VC++, it just describes:<br>
<br>
<table style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:start;width:1306px;font-style:normal;font-weight:normal;padding:0px;line-height:17px;border-collapse:collapse;text-transform:none;font-size:13px;white-space:normal;font-family:'Segoe UI','Lucida Grande',Verdana,Arial,Helvetica,sans-serif;border:1px solid rgb(187,187,187);word-spacing:0px">
<tbody>
<tr>
<th style="border:1px solid rgb(187,187,187);margin:10px;padding:10px 8px;background-color:rgb(237,237,237);color:rgb(112,112,112);text-align:left">
<p style="color:rgb(42,42,42);margin-top:0px;margin-bottom:0px;padding-bottom:0px;line-height:18px"><span style="font-style:italic">mode</span><span> </span>value</p>
</th>
<th style="border:1px solid rgb(187,187,187);margin:10px;padding:10px 8px;background-color:rgb(237,237,237);color:rgb(112,112,112);text-align:left">
<p style="color:rgb(42,42,42);margin-top:0px;margin-bottom:0px;padding-bottom:0px;line-height:18px">Checks file for</p>
</th>
</tr>
<tr>
<td style="border:1px solid rgb(187,187,187);margin:10px;padding:10px 8px;color:rgb(42,42,42);vertical-align:top">
<p style="color:rgb(42,42,42);margin-top:0px;margin-bottom:0px;padding-bottom:0px;line-height:18px">00</p>
</td>
<td style="border:1px solid rgb(187,187,187);margin:10px;padding:10px 8px;color:rgb(42,42,42);vertical-align:top">
<p style="color:rgb(42,42,42);margin-top:0px;margin-bottom:0px;padding-bottom:0px;line-height:18px">Existence only</p>
</td>
</tr>
<tr>
<td style="border:1px solid rgb(187,187,187);margin:10px;padding:10px 8px;color:rgb(42,42,42);vertical-align:top">
<p style="color:rgb(42,42,42);margin-top:0px;margin-bottom:0px;padding-bottom:0px;line-height:18px">02</p>
</td>
<td style="border:1px solid rgb(187,187,187);margin:10px;padding:10px 8px;color:rgb(42,42,42);vertical-align:top">
<p style="color:rgb(42,42,42);margin-top:0px;margin-bottom:0px;padding-bottom:0px;line-height:18px">Write-only</p>
</td>
</tr>
<tr>
<td style="border:1px solid rgb(187,187,187);margin:10px;padding:10px 8px;color:rgb(42,42,42);vertical-align:top">
<p style="color:rgb(42,42,42);margin-top:0px;margin-bottom:0px;padding-bottom:0px;line-height:18px">04</p>
</td>
<td style="border:1px solid rgb(187,187,187);margin:10px;padding:10px 8px;color:rgb(42,42,42);vertical-align:top">
<p style="color:rgb(42,42,42);margin-top:0px;margin-bottom:0px;padding-bottom:0px;line-height:18px">Read-only</p>
</td>
</tr>
<tr>
<td style="border:1px solid rgb(187,187,187);margin:10px;padding:10px 8px;color:rgb(42,42,42);vertical-align:top">
<p style="color:rgb(42,42,42);margin-top:0px;margin-bottom:0px;padding-bottom:0px;line-height:18px">06</p>
</td>
<td style="border:1px solid rgb(187,187,187);margin:10px;padding:10px 8px;color:rgb(42,42,42);vertical-align:top">
<p style="color:rgb(42,42,42);margin-top:0px;margin-bottom:0px;padding-bottom:0px;line-height:18px">Read and write</p>
</td>
</tr>
</tbody>
</table>
<br>
<a href="http://msdn.microsoft.com/en-us/library/1w06ktdy.aspx" target="_blank">http://msdn.microsoft.com/en-us/library/1w06ktdy.aspx</a><br>
The definition are consistent with unistd.h. <br>
<br>
Test: JPRT and jtreg.<br>
<br>
Thanks<span class="HOEnZb"><font color="#888888"><br>
Yumin<br>
</font></span></div>
</blockquote></div><br></div>