<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi All,<br>
<br>
Could I have a couple for reviews for this small change?<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/8022872/webrev.00/">http://cr.openjdk.java.net/~brutisso/8022872/webrev.00/</a><br>
<br>
This change makes sure that we report "humongous allocation" as the
GC cause when we trigger a young collection because we are
attempting a humongous allocation.<br>
<br>
Before the change a log entry for such a young GC looked like this:<br>
<br>
[GC pause (G1 Evacuation Pause) (young) 1364M->1364M(2048M),
0.0004200 secs]<br>
<br>
After the change it looks like this:<br>
<br>
[GC pause (G1 Humongous Allocation) (young) 1364M->1364M(2047M),
0.0541270 secs]<br>
<br>
While doing this change I realized that the GC cause
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
_g1_inc_collection_pause was only used in one more place. The slow
path for allocations. There is already a cause called
_allocation_failure, so I suggest that we use that one instead. This
will eliminate the need for _g1_inc_collection_pause.<br>
<br>
In that case the webrev will look like this:<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/8022872/webrev_incCause/">http://cr.openjdk.java.net/~brutisso/8022872/webrev_incCause/</a><br>
<br>
I prefer this cleanup, but I'm fine with just doing the first one if
we think _g1_inc_collection_pause cause to keep for some reason.<br>
<br>
Thanks,<br>
Bengt<br>
</body>
</html>