<html><head></head><body bgcolor="#FFFFFF"><div><span class="Apple-style-span" style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); "><div>Question: why is the trace block testing for is_humongus itself?</div><div><br></div><div>I would expect the allocation code to branch somewhere for this condition anyway - would it make more sense to put the trace there? Especially if you want to maintain (and output) additional details/statistics.</div><div><br></div><div>Is PTR_FORMAT right for word_size() and would it be better to output bytes? Is this also available as a event?</div><div><br></div><div>Bernd</div></span><br>Am 13.09.2013 um 08:57 schrieb Stefan Karlsson <<a href="mailto:stefan.karlsson@oracle.com">stefan.karlsson@oracle.com</a>>:<br><br></div><div></div><blockquote type="cite"><div>
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type">
<div class="moz-cite-prefix">On 09/13/2013 08:22 AM, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:5232AF1E.5030108@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Hi Stefan,<br>
<br>
On 9/12/13 10:00 PM, Stefan Karlsson wrote:<br>
</div>
<blockquote cite="mid:52321D71.2070008@oracle.com" type="cite"><a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Estefank/8024751/webrev.00/">http://cr.openjdk.java.net/~stefank/8024751/webrev.00/</a>
<br>
<br>
Small fixes two fix some issues when TraceMetadata* flags are
turned on. <br>
<br>
- TraceMetadataHumongousAllocation crashes. <br>
- TraceMetadataChunkAllocation prints the same block_freelist()
multiple times. <br>
</blockquote>
<br>
Looks good. I'm fine with pushing this as is, but I think I would
have preferred that this code:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<br>
2369 if (next != NULL) {<br>
2370 if (TraceMetadataHumongousAllocation &&<br>
2371 SpaceManager::is_humongous(next->word_size())) {<br>
2372 gclog_or_tty->print_cr(" new humongous chunk word
size " PTR_FORMAT,<br>
2373 next->word_size());<br>
2374 }<br>
2375 }<br>
<br>
was more like:<br>
<br>
2370 if (TraceMetadataHumongousAllocation &&<br>
2371 next != NULL &&
SpaceManager::is_humongous(next->word_size())) {<br>
2372 gclog_or_tty->print_cr(" new humongous chunk word
size " PTR_FORMAT,<br>
2373 next->word_size());<br>
2374 }<br>
<br>
To me it makes it clearer that this is only a tracing section.<br>
</blockquote>
<br>
Fair enough. I'll change it.<br>
<br>
thanks,<br>
StefanK<br>
<blockquote cite="mid:5232AF1E.5030108@oracle.com" type="cite"> <br>
Thanks,<br>
Bengt<br>
<blockquote cite="mid:52321D71.2070008@oracle.com" type="cite"> <br>
thanks, <br>
StefanK <br>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</div></blockquote></body></html>