<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Stefan,<br>
<br>
On 9/12/13 10:00 PM, Stefan Karlsson wrote:<br>
</div>
<blockquote cite="mid:52321D71.2070008@oracle.com" type="cite"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~stefank/8024751/webrev.00/">http://cr.openjdk.java.net/~stefank/8024751/webrev.00/</a>
<br>
<br>
Small fixes two fix some issues when TraceMetadata* flags are
turned on.
<br>
<br>
- TraceMetadataHumongousAllocation crashes.
<br>
- TraceMetadataChunkAllocation prints the same block_freelist()
multiple times.
<br>
</blockquote>
<br>
Looks good. I'm fine with pushing this as is, but I think I would
have preferred that this code:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<br>
2369 if (next != NULL) {<br>
2370 if (TraceMetadataHumongousAllocation &&<br>
2371 SpaceManager::is_humongous(next->word_size())) {<br>
2372 gclog_or_tty->print_cr(" new humongous chunk word
size " PTR_FORMAT,<br>
2373 next->word_size());<br>
2374 }<br>
2375 }<br>
<br>
was more like:<br>
<br>
2370 if (TraceMetadataHumongousAllocation &&<br>
2371 next != NULL &&
SpaceManager::is_humongous(next->word_size())) {<br>
2372 gclog_or_tty->print_cr(" new humongous chunk word
size " PTR_FORMAT,<br>
2373 next->word_size());<br>
2374 }<br>
<br>
To me it makes it clearer that this is only a tracing section.<br>
<br>
Thanks,<br>
Bengt<br>
<blockquote cite="mid:52321D71.2070008@oracle.com" type="cite">
<br>
thanks,
<br>
StefanK
<br>
<br>
<br>
</blockquote>
<br>
</body>
</html>