<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Hi everyone,<br>
<br>
Could I have a couple of reviews for this change?<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/8025228/webrev.00/">http://cr.openjdk.java.net/~brutisso/8025228/webrev.00/</a><br>
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8025228">https://bugs.openjdk.java.net/browse/JDK-8025228</a><br>
<br>
We hit this assert in VirtualSpaceList::get_new_chunk() when we have
an allocation that is larger than VirtualSpaceSize and that is not
aligned with vm_allocation_granularity. The reason is that the
VirtualSpace will grow with sizes aligned to
vm_allocation_granularity but we we only guarantee that the sizes we
want to grow with are page aligned. This means that we only hit this
assert on platforms (Windows) where vm_allocation_granularity >
vm_page_size.<br>
<br>
Since VirtualSpaceSize is vm_allocation_granularity aligned on all
platforms we only hit the assert for allocations larger than that
size due to this line:<br>
<br>
1224 size_t grow_vs_words =<br>
1225 MAX2((size_t)VirtualSpaceSize,
aligned_expand_vs_by_words);<br>
<br>
The fix is to make sure that the grow_vs_words value is
vm_allocation_granularity aligned and not just page size aligned.<br>
<br>
<br>
Testing:<br>
<br>
Added a unit test that fails this way on Windows before my fix:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Running internal VM tests<br>
Running test: TestReservedSpace_test()<br>
Running test: TestReserveMemorySpecial_test()<br>
Running test: TestVirtualSpace_test()<br>
Running test: MetaspaceAux_test()<br>
# To suppress the following error report, specify this argument<br>
# after -XX: or in .hotspotrc: SuppressErrorAt=\metaspace.cpp:1145<br>
#<br>
# A fatal error has been detected by the Java Runtime Environment:<br>
#<br>
# Internal Error (...src\share\vm\memory\metaspace.cpp:1145),
pid=220, tid=3352<br>
# assert(vs_byte_size % os::vm_allocation_granularity() == 0)
failed: Not aligned<br>
<br>
After my fix the test passes on all platforms.<br>
<br>
Ran the UTE test list vm.quick-pcl.testlist. All test pass.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
</body>
</html>