<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 2013-09-30 17:28, Stefan Karlsson
wrote:<br>
</div>
<blockquote cite="mid:5249988C.7040905@oracle.com" type="cite">On
2013-09-30 17:20, Erik Helin wrote:
<br>
<blockquote type="cite">Hi all,
<br>
<br>
this patch fixes an issue where the metaspace memory pool
reports -1 for
<br>
MemoryPoolMXBean.getUsage().getMax(), even though the user has
set
<br>
MaxMetaspaceSize on the command line.
<br>
<br>
The problem is that we in collectorPolicy.cpp use FLAG_SET_ERGO
when
<br>
aligning MaxMetaspaceSize while at the same time relying on
<br>
FLAG_IS_CMDLINE in memoryPool.cpp when deciding what to return
for
<br>
MetaspacePool::calculate_max_size.
<br>
<br>
This patch removes FLAG_SET_ERGO and instead simply sets
<br>
MaxMetaspaceSize.
<br>
<br>
Webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ehelin/8025313/webrev.00/">http://cr.openjdk.java.net/~ehelin/8025313/webrev.00/</a>
<br>
</blockquote>
<br>
Could you also change the setting of MetaspaceSize, so that both
flags are set the same way?
<br>
<br>
Otherwise, this looks good.
<br>
</blockquote>
<br>
You can also remove the
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
is_size_aligned checks:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<pre> 67 if (!is_size_aligned(MaxMetaspaceSize, max_alignment())) {
<span class="changed"> 68 MaxMetaspaceSize = restricted_align_down(MaxMetaspaceSize, max_alignment());</span>
69 }
70
71 if (MetaspaceSize > MaxMetaspaceSize) {
72 FLAG_SET_ERGO(uintx, MetaspaceSize, MaxMetaspaceSize);
73 }
74
75 if (!is_size_aligned(MetaspaceSize, min_alignment())) {
76 FLAG_SET_ERGO(uintx, MetaspaceSize,
77 restricted_align_down(MetaspaceSize, min_alignment()));
78 }
79
80 assert(MetaspaceSize <= MaxMetaspaceSize, "Must be");
81
82 MinMetaspaceExpansion = restricted_align_down(MinMetaspaceExpansion, min_alignment());
83 MaxMetaspaceExpansion = restricted_align_down(MaxMetaspaceExpansion, min_alignment());</pre>
<br>
StefanK<br>
<br>
<blockquote cite="mid:5249988C.7040905@oracle.com" type="cite">
<br>
thanks,
<br>
StefanK
<br>
<br>
<br>
<blockquote type="cite">
<br>
Bug:
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8025313">https://bugs.openjdk.java.net/browse/JDK-8025313</a>
<br>
<br>
Thanks,
<br>
Erik
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>