<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Filipp,<br>
<br>
Thank you for putting this up.<br>
<br>
Here is the review:<br>
<br>
1. Please consider a cleaner way to parse vm options and maybe take
this for reference.
<meta charset="utf-8">
<br>
<br>
/test/gc/init/TestHandleExceedingProcessSizeLimitIn32BitBuilds.java<br>
<br>
2. It's better to make variables explicit: I mean, <br>
<br>
disableGC -> disableExplicitGC<br>
<br>
Thanks.<br>
Tao<br>
<br>
On 10/8/13 8:30 AM, Filipp Zhinkin wrote:
<blockquote cite="mid:52542529.2010601@oracle.com" type="cite">Hi,
<br>
<br>
I would like to get couple reviews on regression test for
DisableExplicitGC flag.
<br>
<br>
It verifies that System.gc() calls did not trigger garbage
collection if DisableExplicitGC is turned on and vice versa.
<br>
<br>
Bug ID: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8026047">https://bugs.openjdk.java.net/browse/JDK-8026047</a>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kshefov/8026047/webrev.00/">http://cr.openjdk.java.net/~kshefov/8026047/webrev.00/</a>
<br>
Testing: manual on local host, automated on various platforms.
<br>
<br>
Thanks,
<br>
Filipp.
<br>
</blockquote>
</body>
</html>