<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Tao,<br>
<br>
thank you for looking at it.<br>
<br>
On 10/08/2013 08:23 PM, Tao Mao wrote:<br>
</div>
<blockquote cite="mid:5254319E.70508@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Filipp,<br>
<br>
Thank you for putting this up.<br>
<br>
Here is the review:<br>
<br>
1. Please consider a cleaner way to parse vm options and maybe
take this for reference.
<meta charset="utf-8">
<br>
<br>
/test/gc/init/TestHandleExceedingProcessSizeLimitIn32BitBuilds.java<br>
</blockquote>
I decided to use such complicated way to parse options, because java
process started<br>
by ProcessBuilder will fail if there are more than one space between
options in test.java.opts.<br>
But I've checked it, and looks like jtreg removes all extra spaces
by itself, so I was doing a redundant work. :)<br>
<br>
And yes, I agree, putting all extra options in array's static
initializer look much cleaner.<br>
<blockquote cite="mid:5254319E.70508@oracle.com" type="cite"> <br>
2. It's better to make variables explicit: I mean, <br>
<br>
disableGC -> disableExplicitGC<br>
</blockquote>
Thank you for pointing on it, I'll fix that.<br>
<br>
Filipp.<br>
<blockquote cite="mid:5254319E.70508@oracle.com" type="cite"> <br>
Thanks.<br>
Tao<br>
<br>
On 10/8/13 8:30 AM, Filipp Zhinkin wrote:
<blockquote cite="mid:52542529.2010601@oracle.com" type="cite">Hi,
<br>
<br>
I would like to get couple reviews on regression test for
DisableExplicitGC flag. <br>
<br>
It verifies that System.gc() calls did not trigger garbage
collection if DisableExplicitGC is turned on and vice versa. <br>
<br>
Bug ID: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8026047">https://bugs.openjdk.java.net/browse/JDK-8026047</a>
<br>
Webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ekshefov/8026047/webrev.00/">http://cr.openjdk.java.net/~kshefov/8026047/webrev.00/</a>
<br>
Testing: manual on local host, automated on various platforms. <br>
<br>
Thanks, <br>
Filipp. <br>
</blockquote>
</blockquote>
<br>
</body>
</html>