<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
On 10/9/13 9:53 AM, Filipp Zhinkin wrote:
<blockquote cite="mid:52558A0A.2050401@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi Bengt,<br>
<br>
thank you for looking at it!<br>
<br>
On 10/09/2013 04:12 PM, Bengt Rutisson wrote:<br>
</div>
<blockquote cite="mid:52554836.6010200@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Hi Filipp,<br>
<br>
A couple of comments.<br>
<br>
The
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
@bug 8026047 tag refers to:<br>
<br>
JDK-8026047: [TESTBUG] add regression test for
DisableExplicitGC flag <br>
<br>
Which is just the bug to implement this test. I thought the
@bug tag was normally used to identify the bug which was filed
to report a failure that the test is designed to verify
regressions against. So, in this case I guess there is no such
bug, right? There are no issue with DisableExplicitGC that I
am aware of (which makes me wonder why it is important to
invest time in this right now, but that is a different
topic.). I would suggest to not have the @bug in this case.<br>
</div>
</blockquote>
Yes, I agree.<br>
<blockquote cite="mid:52554836.6010200@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
Why do you do 100 System.gc() calls? Isn't one enough?<br>
</div>
</blockquote>
Just to be sure that particular GC didn't avoid single System.gc()
for some reason.<br>
While such case does not looks realistic at the moment, who knows
what could happen. :)<br>
</blockquote>
If that is the case, you should be glad that your test's caught
something. :)<br>
<br>
<blockquote cite="mid:52558A0A.2050401@oracle.com" type="cite">
<blockquote cite="mid:52554836.6010200@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
Why do you need this:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
options = options.replaceAll("-Xloggc:[^ ]*", "");<br>
<br>
Are you worried that the OutputAlayzer won't work if output is
piped to a file? </div>
</blockquote>
Yes, it is done to guarantee that GC log will be in stdout.<br>
<blockquote cite="mid:52554836.6010200@oracle.com" type="cite">
<div class="moz-cite-prefix">In that case shouldn't that
functionality be in ProcessTools rather than in the test?<br>
</div>
</blockquote>
That sounds reasonable.<br>
<br>
Thanks,<br>
Filipp.<br>
<blockquote cite="mid:52554836.6010200@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
Thanks,<br>
Bengt<br>
<br>
On 10/8/13 5:30 PM, Filipp Zhinkin wrote:<br>
</div>
<blockquote cite="mid:52542529.2010601@oracle.com" type="cite">Hi,
<br>
<br>
I would like to get couple reviews on regression test for
DisableExplicitGC flag. <br>
<br>
It verifies that System.gc() calls did not trigger garbage
collection if DisableExplicitGC is turned on and vice versa. <br>
<br>
Bug ID: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8026047">https://bugs.openjdk.java.net/browse/JDK-8026047</a>
<br>
Webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ekshefov/8026047/webrev.00/">http://cr.openjdk.java.net/~kshefov/8026047/webrev.00/</a>
<br>
Testing: manual on local host, automated on various platforms.
<br>
<br>
Thanks, <br>
Filipp. <br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
</body>
</html>