<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I think this looks great.<br>
<br>
/Fredrik<br>
<br>
<div class="moz-cite-prefix">On 2013-10-15 09:42,
<a class="moz-txt-link-abbreviated" href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:<br>
</div>
<blockquote cite="mid:525CF1F1.1010400@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
There are two questions on the list that we still need to
resolve in this fix:<br>
(1) What is the best way to protect the work with CLDG from
concurrent additions of CLD's to it<br>
(2) The <b>GetClassLoaderClasses</b> needs a fix as well to be
consistent with the GetLoadedClasses<br>
<br>
I had some private conversations with Fredrik and John Rose and<br>
after some analysis came up with the suggestion:<br>
<br>
(1) Continue using the <b>SystemDictionary_lock</b> to
protect consistency of the loaded classes data.<br>
The issue is that adding CLD's to the SLDG is not
currently protected by the <b>SystemDictionary_lock</b>.<br>
I'm suggesting to add it to the <b>SystemDictionary::parse_stream</b>
(please, see the webrev below).<br>
<br>
(2) There was some doubt that a similar fix for the <b>GetClassLoaderClasses</b>
is needed because<br>
the CL+SD (taken from the host class) does not reference
the associated anonymous classes.<br>
The question is: Can we consider the host's class CL as
the initiating CL?<br>
My reading is that the answer to this question is: "Yes,
we can".<br>
Even though the CL itself does not have references to its
anonymous classes,<br>
there are references from the anonymous classes's CLD's
to its CL.<br>
These references can be used in the <b>increment_with_loader</b>
and <b>add_with_loader</b><br>
the same way as it was before.<br>
<br>
This is a webrev that includes the Fredrik's fix as a base plus
the implemented suggestion:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2013/hotspot/fredrik/8024423-JVMTI-ANO/">http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2013/hotspot/fredrik/8024423-JVMTI-ANO/</a><br>
<br>
Some help from the HotSpot team is needed to estimate if this
approach is Ok and does not have rat holes in it.<br>
Opinions are very welcome.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 10/2/13 2:28 AM, Fredrik Arvidsson wrote:<br>
</div>
<blockquote cite="mid:524BE733.2070205@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi and thanks for all your comments.<br>
<br>
I have simplified the code in <b>instanceKlass.cpp</b> like
suggested and here is a new webrev:<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eallwin/farvidss/8024423/webrev.01/">http://cr.openjdk.java.net/~allwin/farvidss/8024423/webrev.01/</a><br>
<br>
Regarding the need to synchronize the access to
ClassLoaderDataGraph I have come to the conclusion that it
should be safe to call this without any additional
synchronization since newly loaded and added classes are
appended to the end of its 'list' of classes. This would mean
that the call could 'miss' the classes added during the
collection phase, but this is not a big issue. I hope that my
conclusion is correct.<br>
<br>
I believe that the
JvmtiGetLoadedClasses::getClassLoaderClasses(...) method is to
be left alone this time since I got the impression that only
SystemDictionary 'knows' about initiating class loaders.<br>
<br>
There is plenty of room for improvement and simplification of
much of the code in this area, but I feel that it must wait
until another time. The task to re-factor and simplify would
quickly grow out of hands I'm afraid :)<br>
<br>
Cheers<br>
/Fredrik<br>
<br>
<div class="moz-cite-prefix">On 2013-10-01 09:34, <a
moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>
wrote:<br>
</div>
<blockquote cite="mid:524A7B07.1000300@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi Frederik,<br>
<br>
<br>
Thank you for jumping on this issue!<br>
<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<b>src/share/vm/oops/instanceKlass.cpp</b><br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<pre><span class="new">2333 int src_index = 0;</span>
2334 while (src_index < src_length) {
2335 dest[dest_index++] = src[src_index++];
2336 }
<span class="new">2337 </span>
<span class="new">2338 // If we have a hash, append it</span>
<span class="new">2339 if(hash_len > 0) {</span>
<span class="new">2340 int hash_index = 0;</span>
<span class="new">2341 while (hash_index < hash_len) {</span>
<span class="new">2342 dest[dest_index++] = hash_buf[hash_index++];</span>
<span class="new">2343 }</span>
<span class="new">2344 }
The above can be simplified a little bit:
// Add the actual class name
for (int src_index = 0; src_index < src_length; ) {
dest[dest_index++] = src[src_index++];
}
// If we have a hash, append it
for (int hash_index = 0; hash_index < hash_len; ) {
dest[dest_index++] = hash_buf[hash_index++];
}
The condition </span><span class="new">if(hash_len > 0)</span> is covered by the loop itself.
Style-related comments:
- <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"><span class="new">wrong indent at the lines: 2316</span>-2319
- need a space after the 'if' at the lines: 2315, 2339
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"><b>src/share/vm/prims/jvmtiGetLoadedClasses.cpp
</b>The copyright comment must be up-to-date.
The comments at the lines 35-38, 258-260 are not valid anymore.
> In this review I still have an outstanding unanswered question about
> the need to synchronize the access to the:
<span class="new" style="color: blue; font-weight: normal;">> ClassLoaderDataGraph::classes_do(&JvmtiGetLoadedClassesClosure::increment);
<font color="#000000">> and</font>
</span><span class="new" style="color: blue; font-weight: normal;">> ClassLoaderDataGraph::classes_do(&JvmtiGetLoadedClassesClosure::add);</span>
This kind of walking is usually done at safepoint in a VM_Operation.
You will find many examples in the jvmtiEnv.cpp, for instance, VM_GetAllStackTraces.
The suggestion from Mikael is good too.
Should this fix include the getClassLoaderClasses() as well?
I'm still trying to realize the impact and consistency of this fix. :(
What tests are you going to run for verification?
Thanks,
Serguei
<b>
</b>On 9/30/13 4:45 AM, Fredrik Arvidsson wrote:
</pre>
</div>
<blockquote cite="mid:5249643F.3030209@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi<br>
<br>
Please help me to review the changes below:<br>
<br>
Jira case: <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8024423">https://bugs.openjdk.java.net/browse/JDK-8024423</a><br>
Webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eallwin/farvidss/8024423/webrev.00/">http://cr.openjdk.java.net/~allwin/farvidss/8024423/webrev.00/</a><br>
<br>
In this review I still have an outstanding unanswered
question about the need to synchronize the access to the:<br>
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="new" style="color: blue; font-weight: normal;">ClassLoaderDataGraph::classes_do(&JvmtiGetLoadedClassesClosure::increment);
<font color="#000000">and</font>
</span><span class="new" style="color: blue; font-weight: normal;">ClassLoaderDataGraph::classes_do(&JvmtiGetLoadedClassesClosure::add);</span>
calls in
<a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Eallwin/farvidss/8024423/webrev.00/src/share/vm/prims/jvmtiGetLoadedClasses.cpp.udiff.html">http://cr.openjdk.java.net/~allwin/farvidss/8024423/webrev.00/src/share/vm/prims/jvmtiGetLoadedClasses.cpp.udiff.html</a>
Please give me advise on this.
There will be a review soon regarding re-enabling the tests that failed because of the above bug, see:
<a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-8025576">https://bugs.openjdk.java.net/browse/JDK-8025576</a>
Cheers
/Fredrik
</pre>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>