<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
Thanks for looking at this, Ramki!<br>
<br>
Bengt<br>
<br>
<div class="moz-cite-prefix">On 2013-10-25 20:14, Srinivas
Ramakrishna wrote:<br>
</div>
<blockquote
cite="mid:CABzyjymZU0Pasu5rd+ozpPhk=cg_tDLt5zz6o9Uu7JsnxxH9Jg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>+1.<br>
<br>
</div>
yes, it would be good to get rid of the extra code in the
future.<br>
<br>
</div>
<div>reviewed webrev.<br>
</div>
-- ramki<br>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">
On Thu, Oct 24, 2013 at 8:00 AM, Erik Helin <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:erik.helin@oracle.com"
target="_blank">erik.helin@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Bengt,<br>
<br>
looks even better :)<br>
<br>
Thanks,<br>
<div class="HOEnZb">
<div class="h5">Erik<br>
<br>
On 2013-10-24, Bengt Rutisson wrote:<br>
><br>
> Thanks for the reviews Erik and Stefan!<br>
><br>
> Thomas suggested to add a JTreg test for these
flags. Here is a<br>
> webrev with the same code change as before but with
a test added:<br>
><br>
> <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebrutisso/8027132/webrev.01/"
target="_blank">http://cr.openjdk.java.net/~brutisso/8027132/webrev.01/</a><br>
><br>
> Thanks, Thomas for pointing this out.<br>
><br>
> Bengt<br>
><br>
><br>
> On 2013-10-24 14:26, Erik Helin wrote:<br>
> >Hi Bengt,<br>
> ><br>
> >looks good, thanks for doing this!<br>
> ><br>
> >Erik<br>
> ><br>
> >On 2013-10-24, Bengt Rutisson wrote:<br>
> >>Hi all,<br>
> >><br>
> >>Can I have a couple of reviews for this
small change?<br>
> >><br>
> >><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebrutisso/8027132/webrev.00/"
target="_blank">http://cr.openjdk.java.net/~brutisso/8027132/webrev.00/</a><br>
> >><br>
> >>CR: <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8027132"
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8027132</a><br>
> >><br>
> >>Background from the CR:<br>
> >><br>
> >>Normally CMS reverts to the SerialOld GC
when it needs to do a full<br>
> >>GC. There is a mode in CMS to instead use
the "foreground<br>
> >>collector". This is a single threaded
stop-the-world mode which<br>
> >>completes an ongoing concurrent CMS
collection (a normal<br>
> >>"background" collection in CMS).<br>
> >><br>
> >>The foreground collector is very slow and
to enable it two flags are<br>
> >>required. First
-XX:-UseCMSCompactAtFullCollection needs to be added<br>
> >>to the command line to turn off the
SerialOld collector, then<br>
> >>-XX:CMSFullGCsBeforeCompaction needs to be
set to a value greater<br>
> >>than 0.<br>
> >><br>
> >>The foreground collector adds a lot of
complexity to the CMS code<br>
> >>but has few (if any?) use cases. Thus, it
would be good to remove it<br>
> >>to simplify the code. In order to remove it
we need to deprecate it<br>
> >>first. This bug report is only about
deprecating the flags to allow<br>
> >>us to remove the foreground collector in a
future release.<br>
> >><br>
> >>The following flags should log a warning
message that they are<br>
> >>deprecated, but the VM should still
continue to work when they are<br>
> >>used:<br>
> >><br>
> >>UseCMSCompactAtFullCollection<br>
> >>CMSFullGCsBeforeCompaction<br>
> >>UseCMSCollectionPassing<br>
> >><br>
> >>Thanks,<br>
> >>Bengt<br>
><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>