<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><div class="im"><blockquote type="cite">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><br>
            <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div bgcolor="#FFFFFF" text="#000000">
                <div> <br>
                  os_linux_x86.cpp<br>
                  <br>
                  This is where the important part of your change is. I
                  don't know enough about Linux internals to validate
                  the changes you have made there. I will leave that out
                  of my review and let others (Runtime team?) with more
                  Linux knowledge review it.<br>
                  <br>
                  <br>
                  Some code comments:<br>
                  <br>
                  Since core_count() returns 0 for all platforms except
                  linux_x86, couldn't the following code be moved to a
                  platform independent place?<br>
                  <br>
                   758 int os::active_core_count() {<br>
                   759   if (os::core_count() <= 0) {<br>
                   760    
                  os::set_core_count(os::active_processor_count());<br>
                   761   }<br>
                   762   return os::core_count();<br>
                   763 }<br>
                  <br>
                  That way this code would not have to be duplicated in
                  all other platforms:<br>
                  <br>
                   726 int os::active_core_count() {<br>
                   727   return os::active_processor_count();<br>
                   728 }<br>
                  <br>
                  We could just always use os::active_core_count() and
                  rely on the value it returns.<br>
                </div>
              </div>
            </blockquote>
            <div><br>
            </div>
            <div>Sounds good to me.</div>
          </div>
        </div>
      </div>
    </blockquote>
    <br></div>
    Good.<div class="im"><br></div></div></blockquote><div><br></div><div>I am now working on this update. If we pull os::active_core_count() to os.cpp, where should the linux_x86 version be?</div><div><br></div><div><br>
</div><div>Jungwoo</div></div></div></div>