<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix"><br>
Hi Thomas,<br>
<br>
This looks good to me.<br>
<br>
One minor thing that I leave up to you to fix if you want to.<br>
<br>
It seems more natural to me to pass an "is parallel" value to the
constructor of
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
G1StringSymbolTableUnlinkTask rather than have it look at
G1CollectedHeap::use_parallel_gc_threads() itself to set the
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
_do_in_parallel value.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
On 2/3/14 5:04 PM, Thomas Schatzl wrote:<br>
</div>
<blockquote cite="mid:1391443461.2586.74.camel@cirrus" type="cite">
<pre wrap="">Hi all,
can I have reviews for the following change? It fixes the check that
verify the correct amount of processed entries during string/symbol
table unlink.
The change adds an exception for the non-parallel case (i.e. the checks
will always succeed in that case).
The alternative would be to make the non-parallel case to also "claim"
work, and use the parallel code. That would require somewhat larger
refactoring of the string/symbol table code. In that case it would also
be nice if the string/symbol table iteration did the same. I.e. it seems
a good enough fix for now.
Webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~tschatzl/8033443/webrev/">http://cr.openjdk.java.net/~tschatzl/8033443/webrev/</a>
CR:
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8033443">https://bugs.openjdk.java.net/browse/JDK-8033443</a>
Testing:
jprt, jtreg (all gc tests)
Thomas
</pre>
</blockquote>
<br>
</body>
</html>