<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 2014-02-26 23:08, Jesper Wilhelmsson
wrote:<br>
</div>
<blockquote cite="mid:530E65C9.2000807@oracle.com" type="cite">Hi
again,
<br>
<br>
There have been a lot of new unit tests added in jdk9 so this
change did not apply cleanly to jdk8. Therefore I'm obliged to ask
for a second round of reviews to backport this trivial change.
Sorry for the inconvenience.
<br>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jwilhelm/8035822/webrev.jdk8u/">http://cr.openjdk.java.net/~jwilhelm/8035822/webrev.jdk8u/</a>
<br>
</blockquote>
<br>
You moved the call into INCLUDE_VM_STRUCTS instead of
INCLUDE_ALL_GCS:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<pre>- run_unit_test(TestOldFreeSpaceCalculation_test());
#if INCLUDE_VM_STRUCTS
+ run_unit_test(TestOldFreeSpaceCalculation_test());
run_unit_test(VMStructs::test());
#endif</pre>
<br>
StefanK<br>
<br>
<blockquote cite="mid:530E65C9.2000807@oracle.com" type="cite">
<br>
Thanks,
<br>
/Jesper
<br>
<br>
<br>
Jesper Wilhelmsson skrev 26/2/14 12:31:
<br>
<blockquote type="cite">Hi,
<br>
<br>
Could I have a few reviews of this small change?
<br>
<br>
A few lines of unit test code ended up on the wrong side of an
#ifdef
<br>
INCLUDE_ALL_GCS leading to errors when running the minimal VM.
<br>
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8035822">https://bugs.openjdk.java.net/browse/JDK-8035822</a>
<br>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jwilhelm/8035822/webrev/">http://cr.openjdk.java.net/~jwilhelm/8035822/webrev/</a>
<br>
<br>
Thanks,
<br>
/Jesper
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>