<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Courier;
panose-1:2 7 4 9 2 2 5 2 4 4;}
@font-face
{font-family:Courier;
panose-1:2 7 4 9 2 2 5 2 4 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:9.5pt;
font-family:Courier;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Courier;}
span.removed
{mso-style-name:removed;
color:#444444;
font-style:italic;}
span.new
{mso-style-name:new;
color:blue;
font-weight:normal;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:2058234554;
mso-list-type:hybrid;
mso-list-template-ids:1695046734 174331766 67567641 67567643 67567631 67567641 67567643 67567631 67567641 67567643;}
@list l0:level1
{mso-level-text:"%1\.\)";
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:22.5pt;
text-indent:-18.0pt;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:58.5pt;
text-indent:-18.0pt;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
margin-left:94.5pt;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:130.5pt;
text-indent:-18.0pt;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:166.5pt;
text-indent:-18.0pt;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
margin-left:202.5pt;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:238.5pt;
text-indent:-18.0pt;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:274.5pt;
text-indent:-18.0pt;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
margin-left:310.5pt;
text-indent:-9.0pt;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">could I please get reviews for this change? I please also need a sponsor.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">I would like to get this into 8u20, as 8036330 was downported, too.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">I’d like to make the point of this change clear once more, independent<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">of which compiler does what.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">I think we agree that basically<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"> - a file should include all headers that define symbols or include
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"> method bodies used in that file
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"> - a .hpp header should not include a .inline.hpp header<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">This is violated <o:p>
</o:p></span></p>
<p class="MsoListParagraph" style="margin-left:22.5pt;text-indent:-18.0pt;mso-list:l0 level1 lfo1">
<![if !supportLists]><span lang="EN-US" style="color:#1F497D"><span style="mso-list:Ignore">1.)<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span lang="EN-US" style="color:#1F497D">by defining
<o:p></o:p></span></p>
<p class="MsoNormal"><i><span lang="EN-US" style="font-size:9.5pt;font-family:Courier;color:#444444;mso-fareast-language:DE"> </span></i><span lang="EN" style="font-size:9.5pt;font-family:Courier;color:#444444;mso-fareast-language:DE">template <class T> void
immediate_rs_update(HeapRegion* from, T* p, int tid) {</span><span lang="EN" style="font-size:9.5pt;font-family:Courier;mso-fareast-language:DE"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="font-size:9.5pt;font-family:Courier;color:#444444;mso-fareast-language:DE"> if (!from->is_survivor()) {</span><span lang="EN" style="font-size:9.5pt;font-family:Courier;mso-fareast-language:DE"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="font-size:9.5pt;font-family:Courier;color:#444444;mso-fareast-language:DE"> _g1_rem->par_write_ref(from, p, tid);</span><span lang="EN" style="font-size:9.5pt;font-family:Courier;mso-fareast-language:DE"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="font-size:9.5pt;font-family:Courier;color:#444444;mso-fareast-language:DE"> }</span><span lang="EN" style="font-size:9.5pt;font-family:Courier;mso-fareast-language:DE"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="font-size:9.5pt;font-family:Courier;color:#444444;mso-fareast-language:DE">}</span><span lang="EN" style="font-size:9.5pt;font-family:Courier;color:#1F497D;mso-fareast-language:DE"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="font-size:9.5pt;font-family:Courier;color:#1F497D;mso-fareast-language:DE"></span><span lang="EN" style="font-size:9.5pt;color:#1F497D;mso-fareast-language:DE"> in
</span><span lang="EN" style="color:#1F497D">g1CollectedHeap.hpp, as par_write_ref in declared ‘inline’ and only defined in
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="color:#1F497D"> <span class="new"><span style="color:#1F497D">g1RemSet.inline.hpp – which is not included and should not be included<o:p></o:p></span></span></span></p>
<p class="MsoNormal"><span class="new"><span lang="EN" style="color:#1F497D"> in g1CollectedHeap.hpp.<o:p></o:p></span></span></p>
<p class="MsoNormal"><span class="new"><span lang="EN" style="color:#1F497D">2. by including<i>
</i></span></span><span class="removed"><span lang="EN" style="color:#1F497D;font-style:normal">g1CollectedHeap.inline.hpp</span></span><span class="removed"><span lang="EN" style="color:#1F497D">
</span></span><span class="removed"><span lang="EN" style="color:#1F497D;font-style:normal">in</span></span><span class="removed"><span lang="EN" style="color:#1F497D">
</span></span><span lang="EN" style="color:#1F497D">sparsePRT.hpp<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="color:#1F497D">This change fixes these two points by moving functions into .inline.hpp files<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="color:#1F497D">and fixing the include.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="color:#1F497D">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="color:#1F497D"> Goetz.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="margin-left:22.5pt"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:DE">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:DE"> Lindenmaier,
Goetz <br>
<b>Sent:</b> Donnerstag, 27. März 2014 17:46<br>
<b>To:</b> hotspot-dev@openjdk.java.net; hotspot-gc-dev@openjdk.java.net<br>
<b>Subject:</b> RFR(M): 8038498: Fix includes and C inlining after 8035330<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Please review and test this change. I please need a sponsor:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="http://cr.openjdk.java.net/~goetz/webrevs/8038498-incl/">http://cr.openjdk.java.net/~goetz/webrevs/8038498-incl/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Change 8035330: Remove G1ParScanPartialArrayClosure and G1ParScanHeapEvacClosure<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">broke the dbg build on AIX. That's because do_oop_partial_array() is added in<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">a header, but requires inline function par_write_ref() through several inlined<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">calls. In some cpp files, like arguments.cpp, par_write_ref() is not defined<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">as the corresponding inline header is not included. The aix debug VM does not start.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">This can be solved by including g1RemSet.inline.hpp in g1CollectedHeap.inline.hpp.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Unfortunately this now causes a cyclic dependency that breaks the linux build.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">A inline.hpp file is included ahead of a .hpp file, so that the code in the inline.hpp file<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">can not see the class declaration.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">This is caused because g1CollectedHeap.inline.hpp is included in sparsePRT.hpp.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">But .inline.hpp files never should be included in .hpp files.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">To resolve this, I changed this inlcude to g1CollectedHeap.hpp. As consequence,
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I had to move a row of functions to existing .inline.hpp files.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I did debug, fastdebug and product builds on linux_ppc64, aix_ppc64,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">sun_64, bsd_x86_64 and linux_x86_64 and tested that the VM starts up.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> Goetz<o:p></o:p></span></p>
</div>
</body>
</html>