<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Stefan, <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">thanks for pointing me to that.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">I think I did that to break the chain at some point.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">But I only need to move two more functions so that all is
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">in the .inline file:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><a href="http://cr.openjdk.java.net/~goetz/webrevs/8038498-incl/webrev.01/">http://cr.openjdk.java.net/~goetz/webrevs/8038498-incl/webrev.01/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> Goetz.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:DE">
Stefan Karlsson [mailto:stefan.karlsson@oracle.com] <br>
<b>Sent:</b> Dienstag, 1. April 2014 10:34<br>
<b>To:</b> Lindenmaier, Goetz; hotspot-dev@openjdk.java.net; hotspot-gc-dev@openjdk.java.net<br>
<b>Subject:</b> Re: RFR(M): 8038498: Fix includes and C inlining after 8035330<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi Goetz,<br>
<br>
Thanks for fixing this!<br>
<br>
One comment below:<o:p></o:p></p>
<div>
<p class="MsoNormal">On 2014-03-27 17:45, Lindenmaier, Goetz wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span lang="EN-US">Hi,</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Please review and test this change. I please need a sponsor:</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"><a href="http://cr.openjdk.java.net/%7Egoetz/webrevs/8038498-incl/">http://cr.openjdk.java.net/~goetz/webrevs/8038498-incl/</a></span><o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif";mso-fareast-language:DE"><br>
<a href="http://cr.openjdk.java.net/~goetz/webrevs/8038498-incl/webrev.00/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp.udiff.html">http://cr.openjdk.java.net/~goetz/webrevs/8038498-incl/webrev.00/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp.udiff.html</a><br>
<br>
I'm not sure what the performance implication is of moving these functions to the .cpp file. Is there a reason why we wouldn't want to put them in the g1CollectedHeap.inline.hpp file?<br>
<br>
thanks,<br>
StefanK<br>
<br>
<br>
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Change 8035330: Remove G1ParScanPartialArrayClosure and G1ParScanHeapEvacClosure</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">broke the dbg build on AIX. That's because do_oop_partial_array() is added in</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">a header, but requires inline function par_write_ref() through several inlined</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">calls. In some cpp files, like arguments.cpp, par_write_ref() is not defined</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">as the corresponding inline header is not included. The aix debug VM does not start.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">This can be solved by including g1RemSet.inline.hpp in g1CollectedHeap.inline.hpp.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Unfortunately this now causes a cyclic dependency that breaks the linux build.
</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">A inline.hpp file is included ahead of a .hpp file, so that the code in the inline.hpp file</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">can not see the class declaration.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">This is caused because g1CollectedHeap.inline.hpp is included in sparsePRT.hpp.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">But .inline.hpp files never should be included in .hpp files.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">To resolve this, I changed this inlcude to g1CollectedHeap.hpp. As consequence,
</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">I had to move a row of functions to existing .inline.hpp files.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">I did debug, fastdebug and product builds on linux_ppc64, aix_ppc64,</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">sun_64, bsd_x86_64 and linux_x86_64 and tested that the VM starts up.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Best regards,</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> Goetz</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif";mso-fareast-language:DE"><o:p> </o:p></span></p>
</div>
</body>
</html>