<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Goetz,<br>
<br>
Thanks for fixing this!<br>
<br>
One comment below:<br>
<br>
<div class="moz-cite-prefix">On 2014-03-27 17:45, Lindenmaier, Goetz
wrote:<br>
</div>
<blockquote
cite="mid:4295855A5C1DE049A61835A1887419CC2CEAAA44@DEWDFEMB12A.global.corp.sap"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 14 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Please review and test
this change. I please need a sponsor:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Egoetz/webrevs/8038498-incl/">http://cr.openjdk.java.net/~goetz/webrevs/8038498-incl/</a></span></p>
</div>
</blockquote>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~goetz/webrevs/8038498-incl/webrev.00/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp.udiff.html">http://cr.openjdk.java.net/~goetz/webrevs/8038498-incl/webrev.00/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp.udiff.html</a><br>
<br>
I'm not sure what the performance implication is of moving these
functions to the .cpp file. Is there a reason why we wouldn't want
to put them in the g1CollectedHeap.inline.hpp file?<br>
<br>
thanks,<br>
StefanK<br>
<br>
<blockquote
cite="mid:4295855A5C1DE049A61835A1887419CC2CEAAA44@DEWDFEMB12A.global.corp.sap"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Change 8035330: Remove
G1ParScanPartialArrayClosure and G1ParScanHeapEvacClosure<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">broke the dbg build on
AIX. That's because do_oop_partial_array() is added in<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">a header, but requires
inline function par_write_ref() through several inlined<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">calls. In some cpp
files, like arguments.cpp, par_write_ref() is not defined<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">as the corresponding
inline header is not included. The aix debug VM does not
start.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">This can be solved by
including g1RemSet.inline.hpp in g1CollectedHeap.inline.hpp.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Unfortunately this now
causes a cyclic dependency that breaks the linux build.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">A inline.hpp file is
included ahead of a .hpp file, so that the code in the
inline.hpp file<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">can not see the class
declaration.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">This is caused because
g1CollectedHeap.inline.hpp is included in sparsePRT.hpp.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">But .inline.hpp files
never should be included in .hpp files.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">To resolve this, I
changed this inlcude to g1CollectedHeap.hpp. As
consequence,
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I had to move a row of
functions to existing .inline.hpp files.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I did debug, fastdebug
and product builds on linux_ppc64, aix_ppc64,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">sun_64, bsd_x86_64 and
linux_x86_64 and tested that the VM starts up.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> Goetz<o:p></o:p></span></p>
</div>
</blockquote>
<br>
</body>
</html>