<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Thanks for the reviews Stefan and Jon!<br>
<br>
Bengt<br>
<br>
On 4/1/14 12:41 AM, Jon Masamitsu wrote:<br>
</div>
<blockquote cite="mid:5339EF1D.5040908@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Looks good.<br>
<br>
Reviewed.<br>
<br>
Jon<br>
<br>
<div class="moz-cite-prefix">On 3/31/14 8:14 AM, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:5339863A.5020106@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<br>
Hi everyone,<br>
<br>
Could I have a couple of reviews of this very small fix to some
assert messages:<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/8038829/webrev.00/">http://cr.openjdk.java.net/~brutisso/8038829/webrev.00/</a><br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8038829">https://bugs.openjdk.java.net/browse/JDK-8038829</a><br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
In VerifyRegionListsClosure::doHeapRegion() the assert messages
print the region_num() value of the heap region. This value is
the the number of regions that a humongous object covers. It is
only relevant for starts humongous regions. For all other
regions this value is 1. <br>
<br>
Most likely the intended value was hrs_index(), which is a
sequential number enumerating all heap regions. <br>
<br>
Thanks,<br>
Bengt<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>