<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Poonam,<br>
<br>
In jdk7 I think there is a <br>
<br>
GenCollectedHeap::print_perm_heap_change()<br>
<br>
Your changes have added in G1CollectorPolicy<br>
<pre><span class="new">1168 void G1CollectorPolicy::print_perm_heap_change(size_t perm_prev_used) const {
</span><span class="new"></span>
</pre>
Is there still a GenCollectedHeap::print_perm_heap_change() in the
jdk7<br>
you're fixing and could you have used that instead of adding the<br>
print_perm_heap_change() to G1CollectorPolicy.<br>
<br>
<br>
<pre><span class="new"></span></pre>
Jon<br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 4/16/2014 6:03 PM, Poonam Bajaj
wrote:<br>
</div>
<blockquote cite="mid:534F2877.50303@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
Hi,<br>
<br>
Could I have reviews for the following fix:<br>
<br>
<a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8010738">JDK-8010738</a>:
G1: Output for full GCs with +PrintGCDetails should contain perm
gen/meta data size change info<br>
webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epoonam/8010738/webrev.00/">http://cr.openjdk.java.net/~poonam/8010738/webrev.00/</a><br>
<br>
With JDK7 G1GC when we use -XX:+PrintGCDetails option, PermGen
information does not get printed in the Full GC logs as shown
below:<br>
[Full GC 16M->16M(20M), 0.7055536 secs]<br>
[Eden: 0.0B(1024.0K)->0.0B(1024.0K) Survivors: 0.0B->0.0B
Heap: 16.7M(20.0M)->16.7M(20.0M)]<br>
<br>
PermGen info should also get printed with Full GC info similar to
what other garbage collectors report. These changes are backport
of the fix in jdk8 where MetaSpace info gets printed in the Full
GC logs.<br>
<br>
With the fix the output looks like:<br>
[Full GC 16M->16M(20M), 0.6763478 secs]<br>
[Eden: 0.0B(1024.0K)->0.0B(1024.0K) Survivors: 0.0B->0.0B
Heap: 16.7M(20.0M)->16.7M(20.0M)], [Perm:
1725K->1725K(16384K)]<br>
<br>
<br>
Thanks,<br>
Poonam<br>
<br>
</blockquote>
<br>
</body>
</html>