<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<div class="moz-cite-prefix">On 2014-05-08 13:33, Andreas Sjöberg
wrote:<br>
</div>
<blockquote cite="mid:536B6B82.3050502@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi,<br>
<br>
I removed the duplicate asserts.<br>
Here's a new webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/JDK-8042474/01/webrev/">http://cr.openjdk.java.net/~brutisso/JDK-8042474/02/webrev/</a><br>
</blockquote>
<br>
Looks good.<br>
<br>
<blockquote cite="mid:536B6B82.3050502@oracle.com" type="cite"> <br>
As for the general cleanup of unused methods, I will do that as a
separate CR.<br>
</blockquote>
<br>
Sounds good to me.<br>
<br>
Bengt<br>
<br>
<blockquote cite="mid:536B6B82.3050502@oracle.com" type="cite"> <br>
Thanks for looking at this,<br>
Andreas<br>
<div class="moz-cite-prefix">On 05/08/2014 10:20 AM, Bengt
Rutisson wrote:<br>
</div>
<blockquote cite="mid:536B3E59.6050203@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
Hi Andreas,<br>
<br>
<div class="moz-cite-prefix">On 2014-05-08 10:01, Andreas
Sjöberg wrote:<br>
</div>
<blockquote cite="mid:536B39D0.1070801@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi all,<br>
<br>
could I please have reviews for this small cleanup?<br>
For RSHashTable, it<br>
- removes entry_for_region_ind(RegionIdx_t)<br>
- changes get_entry to be public and declared const<br>
- changes the sites that called entry_for_region to instead
use get_entry, since they have the same implementation.<br>
- changes get_cards to make use of get_entry instead of very
similar code contained inline.<br>
<br>
webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/JDK-8042474/01/webrev/">http://cr.openjdk.java.net/~brutisso/JDK-8042474/01/webrev/</a><br>
</blockquote>
<br>
Looks good. Nice cleanup!<br>
<br>
One minor thing:<br>
<br>
These asserts in RSHashTable::get_cards():<br>
<br>
204 assert(entry->r_ind() == region_ind, "Postcondition of
loop + test above.");<br>
205 assert(entry->num_valid_cards() > 0, "Inv");<br>
<br>
are already done in RSHashTable::get_entry(). I think you can
remove them too.<br>
<br>
<br>
<blockquote cite="mid:536B39D0.1070801@oracle.com" type="cite">
<br>
It seems get_cards is not used. Maybe it should be removed as
a separate CR?<br>
</blockquote>
<br>
Yes it is unused, so it would be good to remove it. I'm fine
with doing that as a separate CR. Maybe in that case also go
through all methods in sparsePRT.hpp and make sure that they are
used.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<blockquote cite="mid:536B39D0.1070801@oracle.com" type="cite">
<br>
testing: jprt.<br>
<br>
Best regards,<br>
Andreas<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>