<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Dima,<br>
<br>
If the test fails, can you print the strings with
System.out.println() or<br>
System.err.println()? Any information about the strings might be<br>
useful to understand why deduplication didn't work or why the<br>
test thinks the deduplication didn't work (in case something<br>
happens that the test doesn't expect)? <br>
<br>
Jon<br>
<br>
<div class="moz-cite-prefix">On 8/6/2014 8:53 AM, Dmitry Fazunenko
wrote:<br>
</div>
<blockquote cite="mid:53E24F6F.5000704@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi, <br>
<br>
Would you please look at the simple fix of String Deduplication
tests. <br>
<br>
Description:<br>
<br>
When string deduplication has happened <i>s1.equals(s2)</i>
will be equivalent to <i>s1 == s2</i><br>
Deduplication is performed in a separate thread so it could be
delayed a bit.<br>
Tests are away about possible delay and give another chance if
deduplication hasn't <br>
happened by the moment of check.<br>
But tests wait for deduplication in infinitive loop, so if
deduplication doesn't work the tests <br>
will timeout, leaving hanging VM after. Which is not very elegant.<br>
<br>
The fix is simple: replace infinitive loops with limited ones and
report failure.<br>
The logic of the tests hasn't changed. <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edfazunen/8050464/webrev.01/">http://cr.openjdk.java.net/~dfazunen/8050464/webrev.01/</a><br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8050464">https://bugs.openjdk.java.net/browse/JDK-8050464</a><br>
<br>
Any comments are welcome.<br>
<br>
Thanks,<br>
Dima<br>
<br>
<br>
<br>
</blockquote>
<br>
</body>
</html>