<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Thomas,<div><br></div><div>The string "<span style="font-family: sans-serif; font-size: 13px; line-height: 17px; background-color: rgb(255, 255, 255);">[GC remark [GC graph-trace, 0.0095070 secs] [GC ref-proc, 0.0151560 secs] [GC string-unlink, 0.0211210 secs] [GC symbol-unlink, 0.0635730 secs] [GC aggregate-data, 0.0102910 secs], 0.1199190 secs] </span><font face="sans-serif" size="2"><span style="line-height: 17px;">“ as listed in the web-rev is fine. This is easily machine parseable and it follows the hyphenated format that has been traditionally used in the GC logs. </span></font><span style="font-family: sans-serif; font-size: small; line-height: 17px;"> My only comment is that</span><span style="font-family: sans-serif; font-size: small; line-height: 17px;"> GC at the beginning of each block is noise but if it makes you happier to have it there... so be it.</span><span style="line-height: 17px; font-family: sans-serif; font-size: small;">If this is the output that you can guarantee and it won’t be corrupted by other records and/or flag settings then I think this breakdown will not only be very useful, it will be appreciated.</span></div><div><font face="sans-serif" size="2"><span style="line-height: 17px;"><br></span></font></div><div><font face="sans-serif" size="2"><span style="line-height: 17px;">Kind regards,</span></font></div><div><font face="sans-serif" size="2"><span style="line-height: 17px;">Kirk Pepperdine</span></font></div><div><font face="sans-serif" size="2"><span style="line-height: 17px;"><br></span></font></div><div><font face="sans-serif" size="2"><span style="line-height: 17px;">PS why I prefer the hyphenated output is that it’s easier pick out in cases where output is mixed with other forms of application logging</span></font></div><div><font face="sans-serif" size="2"><span style="line-height: 17px;"><br></span></font></div><div><font face="sans-serif" size="2"><span style="line-height: 17px;"><br></span></font></div><div><div><div><div>On Sep 22, 2014, at 6:53 AM, Thomas Schatzl <<a href="mailto:thomas.schatzl@oracle.com">thomas.schatzl@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hi,<br><br>On Mon, 2014-09-22 at 15:31 +0200, Stefan Karlsson wrote:<br><blockquote type="cite">On 2014-09-22 11:06, Thomas Schatzl wrote:<br><blockquote type="cite">Hi,<br><br>On Fri, 2014-09-19 at 11:25 -0400, Joseph Provino wrote:<br><blockquote type="cite">Hi all,<br><br>Can I have reviews for the following small change that logs more G1<br>Concurrent Mark<br>Trace Times. I also changed G1RemarkGCTraceTime() to G1CMTraceTime()<br>because it's<br>used in places other than remark.<br><br>CR: <a href="https://bugs.openjdk.java.net/browse/JDK-8027450">https://bugs.openjdk.java.net/browse/JDK-8027450</a><br><br>Webrev:http://<a href="http://cr.openjdk.java.net/~jprovino/8027450/webrev.00/">cr.openjdk.java.net/~jprovino/8027450/webrev.00/</a><br><br>Testing: jprt<br><br>I also need a sponsor to commit the changes.<br></blockquote>Looks good. Maybe the strings could be changed to fit the existing<br>though, e.g. "GC ref-proc" -> "Reference processing", and "GC<br>aggregate-data" -> "Aggregate data".<br></blockquote><br>That might be worth doing, but not as a part of this cleanup. Changing <br>the log output is usually a much greater undertaking than this small <br>cleanup.<br><br></blockquote><br>Fine with me.<br><br>Thanks,<br> Thomas<br><br><br></blockquote></div><br></div></div></body></html>