<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Stefan,<br>
<br>
Thanks for the point.<br>
Here is another webrev worked on "hs-gc".<br>
As you mentioned there are some difference between jdk9-dev and
hs-gc. i.e. some functions are removed in g1ParScanTrheadState.hpp
and g1ParScanTrheadState.inline.hpp in hs-gc.<br>
<br>
Webrev:<br>
<a
href="http://cr.openjdk.java.net/%7Etschatzl/8036116-kim/webrev.01/">http://cr.openjdk.java.net/~tschatzl/8036116-kim/webrev.01/</a><br>
<br>
Thanks,<br>
Sangheon<br>
<br>
<br>
<div class="moz-cite-prefix">On 09/23/2014 06:48 AM, Stefan Karlsson
wrote:<br>
</div>
<blockquote cite="mid:54217A27.30303@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi Sangheon,<br>
<br>
On 23/09/14 15:31, Sangheon Kim wrote:<br>
</div>
<blockquote cite="mid:54217622.8010100@oracle.com" type="cite">Hi
all, <br>
<br>
can I have reviews for the following small change that changes
the <br>
uses of the "int" type for thread ids into uints like everywhere
else? <br>
<br>
Thomas agreed to sponsor the change. <br>
<br>
CR: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8036116">https://bugs.openjdk.java.net/browse/JDK-8036116</a>
<br>
<br>
Webrev: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Etschatzl/8036116-kim/webrev.00/">http://cr.openjdk.java.net/~tschatzl/8036116-kim/webrev.00/</a>
<a moz-do-not-send="true" class="moz-txt-link-rfc2396E"
href="http://cr.openjdk.java.net/%7Etschatzl/8036116-kim/webrev.00/"><http://cr.openjdk.java.net/%7Etschatzl/8036116-kim/webrev.00/></a>
<br>
</blockquote>
<br>
The patch looks good. However, it is based against
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/dev/hotspot">http://hg.openjdk.java.net/jdk9/dev/hotspot</a>
instead of
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/hs-gc/hotspot">http://hg.openjdk.java.net/jdk9/hs-gc/hotspot</a>,
where most of our changes should be pushed to. Parts of the code
you change have already been removed in hs-gc.<br>
<br>
thanks,<br>
StefanK<br>
<br>
<br>
<blockquote cite="mid:54217622.8010100@oracle.com" type="cite"> <br>
Testing: jprt <br>
<br>
Thanks, <br>
Sangheon <br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>