<div dir="ltr">As an outsider... nice work!! Anything that makes the GC subsystem more readable :-)</div><div class="gmail_extra"><br clear="all"><div>Cheers,<br>Martijn</div>
<br><div class="gmail_quote">On 17 October 2014 12:43, Bengt Rutisson <span dir="ltr"><<a href="mailto:bengt.rutisson@oracle.com" target="_blank">bengt.rutisson@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hi everyone,<br>
<br>
Can I have a couple of reviews for this change?<br>
<br>
HotSpot changes:<br>
<a href="http://cr.openjdk.java.net/~brutisso/8061308/hotspot/" target="_blank">http://cr.openjdk.java.net/~<u></u>brutisso/8061308/hotspot/</a><br>
<br>
JDK changes:<br>
<a href="http://cr.openjdk.java.net/~brutisso/8061308/jdk/" target="_blank">http://cr.openjdk.java.net/~<u></u>brutisso/8061308/jdk/</a><br>
(Just a small update to a test library class.)<br>
<br>
JBS bug:<br>
<a href="https://bugs.openjdk.java.net/browse/JDK-8061308" target="_blank">https://bugs.openjdk.java.net/<u></u>browse/JDK-8061308</a><br>
<br>
The change removes the incremental mode of CMS. This work is part of JEP 214 (<a href="http://openjdk.java.net/jeps/214" target="_blank">http://openjdk.java.net/jeps/<u></u>214</a>). There are quite a few lines changed. Mostly it is just removal of code and it should hopefully be fairly straight forward to review.<br>
<br>
One interesting side effect of removing iCMS was that the ConcEdenSpace (a subclass in the Space hierarchy) could be removed. It implemented the "soft-end" feature that only iCMS was taking advantage of. When I had removed ConcEdenSpace it turned out that its superclass, EdenSpace, was actually an unnecessary class that did not add anything so I removed that too. When I then went to update the comment in space.hpp that describes the Space hierarchy I noticed that the description of the hierarchy was completely out-dated. Rather than bringing it up-to-date I removed the comment. I think that type of information will only get out-dated quickly again and it is much easier to let your IDE create the correct type hierarchy view dynamically for you.<br>
<br>
Thanks,<br>
Bengt<br>
</blockquote></div><br></div>