<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Tests look good.<br>
<br>
Reviewed.<br>
<br>
Jon<br>
<br>
<div class="moz-cite-prefix">On 10/31/2014 03:34 AM, Evgeniya
Stepanova wrote:<br>
</div>
<blockquote cite="mid:545365C2.5040609@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Hi Jon!<br>
<br>
Please see comments inline<br>
<div class="moz-cite-prefix">On 31.10.2014 7:45, Jon Masamitsu
wrote:<br>
</div>
<blockquote cite="mid:545305C4.5070901@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Evgeniya,<br>
<br>
I've only look at a few of the files. I'm not sure <br>
I'm interpreting the @requires correctly. If you <br>
reply to these initial comments, that will help<br>
me understand.<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8062537/webrev.00/test/gc/arguments/TestMaxNewSize.java.udiff.html">http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/test/gc/arguments/TestMaxNewSize.java.udiff.html</a><br>
<br>
<pre><span class="new">+ * @requires vm.gc=="null"</span></pre>
Test seems to expect Serial GC. Should the requires<br>
be Serial or null?<br>
</blockquote>
The diff info is not full:<br>
25 * @test TestMaxNewSize<br>
26 * @key gc<br>
27 * @bug 7057939<br>
28 * @requires vm.gc=="null"<br>
29 * @summary Make sure that MaxNewSize always has a useful
value after argument<br>
30 * processing.<br>
31 * @library /testlibrary<br>
32 * @build TestMaxNewSize<br>
33 * @run main TestMaxNewSize -XX:+UseSerialGC<br>
34 * @run main TestMaxNewSize -XX:+UseParallelGC<br>
35 * @run main TestMaxNewSize -XX:+UseConcMarkSweepGC<br>
36 * @run main TestMaxNewSize -XX:+UseG1GC<br>
<br>
So test run with all GCs.<br>
<br>
<blockquote cite="mid:545305C4.5070901@oracle.com" type="cite"> <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8062537/webrev.00/test/gc/arguments/TestSerialHeapSizeFlags.java.udiff.html">http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/test/gc/arguments/TestSerialHeapSizeFlags.java.udiff.html</a><br>
<br>
Comments say this is a test of Serial but null<br>
allowed.<br>
<br>
<pre><span class="new">+ * @requires vm.gc=="Serial" | vm.gc=="null"</span></pre>
<br>
</blockquote>
Test itself set "-XX:+UseSerialGC" flag and launch separate java
process. <br>
Setting @requires in such cases aiming 2 targets:<br>
1)It is skipps if GC is for example ParallelGC. In concrete case
you could guess it only for serial GC, but in some tests you
couldn't.<br>
So you see test passed and think it passed with your options and
actually it passed with other GC. With requires you are totally
sure test run with option you set. I believe such tests should be
changed to pass options to the java processes, but now they
doesn't. <br>
2)From the other hand, when run without options, tests always run
(ALL tests will run, no tests skipped at all)<br>
<br>
<blockquote cite="mid:545305C4.5070901@oracle.com" type="cite"> <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8062537/webrev.00/test/gc/class_unloading/TestCMSClassUnloadingEnabledHWM.java.udiff.html">http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/test/gc/class_unloading/TestCMSClassUnloadingEnabledHWM.java.udiff.html</a><br>
<br>
If you're going to use this on all the collectors (allow vm.gc
== null),<br>
then class loading should be turned off on all the GC's, not<br>
just CMS (-XX:-CMSClassUnloadingEnabled only affects CMS).<br>
</blockquote>
See previous comment. All tests you mentioned were not failed, and
"requires" added for them to make order in test run.<br>
<blockquote cite="mid:545305C4.5070901@oracle.com" type="cite"> <br>
Jon<br>
<br>
<div class="moz-cite-prefix">On 10/30/2014 07:05 AM, Evgeniya
Stepanova wrote:<br>
</div>
<blockquote cite="mid:545245C5.4050504@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
Hi,<br>
<br>
Please review changes for 8062537, the OpenJDK/hotspot part of
the <a moz-do-not-send="true" id="key-val" rel="4684019"
href="https://bugs.openjdk.java.net/browse/JDK-8019361">JDK-8019361</a><br>
<br>
bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8062537">https://bugs.openjdk.java.net/browse/JDK-8062537</a><br>
fix: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8062537/webrev.00/">http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/</a><br>
<br>
Problem: Some tests explicitly set GC and fail when jtreg set
another GC.<br>
Solution: Such tests marked with the jtreg tag "requires" to
skip test if there is a conflict<br>
<br>
Tested locally with different GC flags (-XX:+UseG1GC,
-XX:+UseParallelGC, -XX:+UseSerialGC, -XX:+UseConcMarkSweep
and without any GC flag). Tests are being excluded as
expected. No tests failed because of the conflict.<br>
<br>
Thanks,<br>
Evgeniya Stepanova
<div class="moz-signature"><br>
</div>
</blockquote>
<br>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<i>Evgeniya Stepanova</i></div>
</blockquote>
<br>
</body>
</html>