<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Evgeniya,<br>
<br>
One suggestion on this review.<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/test/gc/defnew/HeapChangeLogging.java.frames.html">http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/test/gc/defnew/HeapChangeLogging.java.frames.html</a><br>
<br>
This part of comment should be deleted.<br>
<pre> 33 * Test the output of G1SummarizeRSetStats in conjunction with G1SummarizeRSetStatsPeriod.</pre>
<br>
The test doesn't use G1.<br>
<br>
Jon<br>
<br>
<br>
<div class="moz-cite-prefix">On 10/30/2014 07:05 AM, Evgeniya
Stepanova wrote:<br>
</div>
<blockquote cite="mid:545245C5.4050504@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
Hi,<br>
<br>
Please review changes for 8062537, the OpenJDK/hotspot part of the
<a moz-do-not-send="true" id="key-val" rel="4684019"
href="https://bugs.openjdk.java.net/browse/JDK-8019361">JDK-8019361</a><br>
<br>
bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8062537">https://bugs.openjdk.java.net/browse/JDK-8062537</a><br>
fix: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8062537/webrev.00/">http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/</a><br>
<br>
Problem: Some tests explicitly set GC and fail when jtreg set
another GC.<br>
Solution: Such tests marked with the jtreg tag "requires" to skip
test if there is a conflict<br>
<br>
Tested locally with different GC flags (-XX:+UseG1GC,
-XX:+UseParallelGC, -XX:+UseSerialGC, -XX:+UseConcMarkSweep and
without any GC flag). Tests are being excluded as expected. No
tests failed because of the conflict.<br>
<br>
Thanks,<br>
Evgeniya Stepanova
<div class="moz-signature"><br>
</div>
</blockquote>
<br>
</body>
</html>