<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
If it's confusing the tests are using -XX:+UseParallelGC we can
change them to use some other neutral flag.<br>
<br>
"Plus there is no any sense to run test twice in TC (with different
GC, since it use only Parallel)"<br>
<br>
I agree it's meaningless to run them with all possible GC
combinations because these tests are GC neutral.<br>
<br>
// Katja <br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 11/06/2014 11:27 AM, Yekaterina
Kantserova wrote:<br>
</div>
<blockquote cite="mid:545B4D0C.2010005@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Hi Evgeniya,<br>
<br>
As David has pointed out these jps tests are not testing gc. The
-XX:+UseParallelGC is just an arbitrary chosen test flag. There
should not be any conflicts either since these tests are running
in driver mode:<br>
<br>
...<br>
 * @run driver TestJpsJar<br>
...<br>
<br>
which means no flags from above are accepted.<br>
<br>
Thanks,<br>
Katja<br>
<br>
<br>
<br>
On 11/06/2014 11:05 AM, Evgeniya Stepanova wrote:<br>
<blockquote cite="mid:545B47FC.1070305@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Hi David,<br>
<br>
tag added because tests contain string<br>
 cmd.addAll(JpsHelper.getVmArgs());<br>
<br>
and JpsHelper defines <br>
...<br>
public static final String[] VM_ARGS = {"-Xmx512m",
"-XX:+UseParallelGC"};<br>
...<br>
public static List<String> getVmArgs() throws IOException
{<br>
       if (testVmArgs == null) {<br>
           testVmArgs = new ArrayList<>();<br>
           testVmArgs.addAll(Arrays.asList(VM_ARGS));<br>
           testVmArgs.add("-XX:Flags=" +
getVmFlagsFile().getAbsolutePath());<br>
       }<br>
       return testVmArgs;<br>
   }<br>
<br>
Tests itself wouldn't fail if we use another GC, tag added for
cleanup-if we use for example SerialGC we must be sure that
tests passed with this GC, not with another one. Now you will
assume that concrete test passed with Serial GC, but it run only
with Parallel GC. Plus there is no any sense to run test twice
in TC (with different GC, since it use only Parallel)<br>
<br>
Thanks,<br>
Evgeniya Stepanova<br>
<div class="moz-cite-prefix">On 06.11.2014 6:20, David Holmes
wrote:<br>
</div>
<blockquote cite="mid:545ADAD7.7040902@oracle.com" type="cite">Hi
Evgeniya, <br>
<br>
On 6/11/2014 1:33 AM, Evgeniya Stepanova wrote: <br>
<blockquote type="cite">Hi, <br>
<br>
Please review changes for 8062536, the OpenJDK/jdk part of
the JDK-8019361 <br>
<br>
bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8062536">https://bugs.openjdk.java.net/browse/JDK-8062536</a>
<br>
fix: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8062536/webrev.00/">http://cr.openjdk.java.net/~eistepan/8062536/webrev.00/</a>
<br>
<br>
Problem: Some tests explicitly set GC and fail when another
GC is set <br>
outside <br>
</blockquote>
<br>
I don't see why you have done this for the <br>
<br>
test/sun/tools/jps/TestJps*.java <br>
<br>
tests. They don't set any GC flags. <br>
<br>
<blockquote type="cite">Solution: Such tests marked with the
jtreg tag "requires" to skip test <br>
if there is a conflict <br>
</blockquote>
<br>
Just wondering: Does a skipped test get a .jtr file showing it
was skipped; or does it only appear in the higher-level jtreg
log? <br>
<br>
Thanks, <br>
David <br>
<br>
<blockquote type="cite">Tested locally with different GC flags
(-XX:+UseG1GC, <br>
-XX:+UseParallelGC, -XX:+UseSerialGC, -XX:+UseConcMarkSweep
and without <br>
any GC flag). Tests are being excluded as expected. No tests
failed <br>
because of the conflict. <br>
<br>
Thanks, <br>
Evgeniya Stepanova <br>
<br>
// <br>
</blockquote>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<i>Evgeniya Stepanova</i></div>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>