<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi David,<br>
<br>
tag added because tests contain string<br>
cmd.addAll(JpsHelper.getVmArgs());<br>
<br>
and JpsHelper defines <br>
...<br>
public static final String[] VM_ARGS = {"-Xmx512m",
"-XX:+UseParallelGC"};<br>
...<br>
public static List<String> getVmArgs() throws IOException {<br>
if (testVmArgs == null) {<br>
testVmArgs = new ArrayList<>();<br>
testVmArgs.addAll(Arrays.asList(VM_ARGS));<br>
testVmArgs.add("-XX:Flags=" +
getVmFlagsFile().getAbsolutePath());<br>
}<br>
return testVmArgs;<br>
}<br>
<br>
Tests itself wouldn't fail if we use another GC, tag added for
cleanup-if we use for example SerialGC we must be sure that tests
passed with this GC, not with another one. Now you will assume that
concrete test passed with Serial GC, but it run only with Parallel
GC. Plus there is no any sense to run test twice in TC (with
different GC, since it use only Parallel)<br>
<br>
Thanks,<br>
Evgeniya Stepanova<br>
<div class="moz-cite-prefix">On 06.11.2014 6:20, David Holmes wrote:<br>
</div>
<blockquote cite="mid:545ADAD7.7040902@oracle.com" type="cite">Hi
Evgeniya,
<br>
<br>
On 6/11/2014 1:33 AM, Evgeniya Stepanova wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
Please review changes for 8062536, the OpenJDK/jdk part of the
JDK-8019361
<br>
<br>
bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8062536">https://bugs.openjdk.java.net/browse/JDK-8062536</a>
<br>
fix: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~eistepan/8062536/webrev.00/">http://cr.openjdk.java.net/~eistepan/8062536/webrev.00/</a>
<br>
<br>
Problem: Some tests explicitly set GC and fail when another GC
is set
<br>
outside
<br>
</blockquote>
<br>
I don't see why you have done this for the
<br>
<br>
test/sun/tools/jps/TestJps*.java
<br>
<br>
tests. They don't set any GC flags.
<br>
<br>
<blockquote type="cite">Solution: Such tests marked with the jtreg
tag "requires" to skip test
<br>
if there is a conflict
<br>
</blockquote>
<br>
Just wondering: Does a skipped test get a .jtr file showing it was
skipped; or does it only appear in the higher-level jtreg log?
<br>
<br>
Thanks,
<br>
David
<br>
<br>
<blockquote type="cite">Tested locally with different GC flags
(-XX:+UseG1GC,
<br>
-XX:+UseParallelGC, -XX:+UseSerialGC, -XX:+UseConcMarkSweep and
without
<br>
any GC flag). Tests are being excluded as expected. No tests
failed
<br>
because of the conflict.
<br>
<br>
Thanks,
<br>
Evgeniya Stepanova
<br>
<br>
//
<br>
</blockquote>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<i>Evgeniya Stepanova</i></div>
</body>
</html>