<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Filipp,<br>
<br>
Ok, then I'll just remove option :)<br>
<br>
Thanks<br>
<div class="moz-cite-prefix">On 06.11.2014 18:02, Filipp Zhinkin
wrote:<br>
</div>
<blockquote cite="mid:545B7F7A.7070406@oracle.com" type="cite">
<meta http-equiv="Context-Type" content="text/html; charset=UTF-8">
<div class="moz-cite-prefix">Hi Evgeniya,<br>
<br>
it seems like there is no need to use Serial GC in
java/lang/ref/EnqueuePollRace.java [1],<br>
so it does make sense to remove that option instead of adding
the @requires tag.<br>
<br>
Thanks,<br>
Filipp.<br>
<br>
[1] <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8051723">https://bugs.openjdk.java.net/browse/JDK-8051723</a><br>
<br>
On 11/06/2014 06:36 PM, Evgeniya Stepanova wrote:<br>
</div>
<blockquote cite="mid:545B8777.6080403@oracle.com" type="cite">
New webrev:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8062536/webrev.01/">http://cr.openjdk.java.net/~eistepan/8062536/webrev.01/</a><br>
<br>
Thanks,<br>
Evgeniya Stepanova<br>
<div class="moz-cite-prefix">On 06.11.2014 17:35, Yekaterina
Kantserova wrote:<br>
</div>
<blockquote cite="mid:545B793D.5000008@oracle.com" type="cite">
Thanks a lot!<br>
<br>
<div class="moz-cite-prefix">On 11/06/2014 02:05 PM, Evgeniya
Stepanova wrote:<br>
</div>
<blockquote cite="mid:545B722C.3020406@oracle.com" type="cite">
Hi Katja,<br>
<br>
Ok, this seems to be a perfect solution. Thank you. I'll
change the diff accordingly.<br>
<br>
<br>
Thanks,<br>
Evgeniya Stepanova<br>
<div class="moz-cite-prefix">On 06.11.2014 16:56, Yekaterina
Kantserova wrote:<br>
</div>
<blockquote cite="mid:545B7006.5080104@oracle.com"
type="cite"> Hi Dima,<br>
<br>
<div class="moz-cite-prefix">On 11/06/2014 11:22 AM,
Dmitry Fazunenko wrote:<br>
</div>
<blockquote cite="mid:545B4BF6.4040209@oracle.com"
type="cite"> Hi Katja,<br>
<br>
You are right, there will be no conflict, because test
ignores any external VM flags.<br>
So, adding @requires seems unnecessary here, but... <br>
<br>
Ignoring external options is bad thing, such "selfish"
tests are not applicable for other areas, like GC,
compiler, RT.<br>
</blockquote>
<br>
This particular case is to test the defined flags are
shown up as expected.<br>
<br>
Evgeniya,<br>
<br>
would you mind to change JpsHelper.java instead?<br>
<br>
+++ b/test/sun/tools/jps/JpsHelper.java<br>
@@ -93,7 +93,7 @@<br>
/**<br>
* VM arguments to start test application with<br>
*/<br>
- public static final String[] VM_ARGS = {"-Xmx512m",
"-XX:+UseParallelGC"};<br>
+ public static final String[] VM_ARGS = {"-Xmx512m",
"-XX:+PrintGCDetails"};<br>
/**<br>
* VM flag to start test application with<br>
*/<br>
<br>
Best regards,<br>
Katja<br>
<br>
<br>
<br>
<blockquote cite="mid:545B4BF6.4040209@oracle.com"
type="cite"> <br>
@requires will allow to modify tests to include
external vm options without any risk of bumping into
conflict and extend area of test applicability.<br>
<br>
But if you still believe, that @requires is not
necessary - it's not a problem, tests could be kept as
is.<br>
<br>
Thanks,<br>
Dima<br>
<br>
<br>
On 06.11.2014 16:27, Yekaterina Kantserova wrote:
<blockquote cite="mid:545B51A1.7080905@oracle.com"
type="cite">
<div class="moz-forward-container"> <br>
Hi Evgeniya,<br>
<br>
As David has pointed out these jps tests are not
testing gc. The -XX:+UseParallelGC is just an
arbitrary chosen test flag. There should not be any
conflicts either since these tests are running in
driver mode:<br>
<br>
...<br>
* @run driver TestJpsJar<br>
...<br>
<br>
which means no flags from above are accepted.<br>
<br>
Thanks,<br>
Katja<br>
<br>
<br>
<br>
On 11/06/2014 11:05 AM, Evgeniya Stepanova wrote:<br>
<blockquote cite="mid:545B47FC.1070305@oracle.com"
type="cite"> Hi David,<br>
<br>
tag added because tests contain string<br>
cmd.addAll(JpsHelper.getVmArgs());<br>
<br>
and JpsHelper defines <br>
...<br>
public static final String[] VM_ARGS =
{"-Xmx512m", "-XX:+UseParallelGC"};<br>
...<br>
public static List<String> getVmArgs()
throws IOException {<br>
if (testVmArgs == null) {<br>
testVmArgs = new ArrayList<>();<br>
testVmArgs.addAll(Arrays.asList(VM_ARGS));<br>
testVmArgs.add("-XX:Flags=" +
getVmFlagsFile().getAbsolutePath());<br>
}<br>
return testVmArgs;<br>
}<br>
<br>
Tests itself wouldn't fail if we use another GC,
tag added for cleanup-if we use for example
SerialGC we must be sure that tests passed with
this GC, not with another one. Now you will assume
that concrete test passed with Serial GC, but it
run only with Parallel GC. Plus there is no any
sense to run test twice in TC (with different GC,
since it use only Parallel)<br>
<br>
Thanks,<br>
Evgeniya Stepanova<br>
<div class="moz-cite-prefix">On 06.11.2014 6:20,
David Holmes wrote:<br>
</div>
<blockquote cite="mid:545ADAD7.7040902@oracle.com"
type="cite">Hi Evgeniya, <br>
<br>
On 6/11/2014 1:33 AM, Evgeniya Stepanova wrote:
<br>
<blockquote type="cite">Hi, <br>
<br>
Please review changes for 8062536, the
OpenJDK/jdk part of the JDK-8019361 <br>
<br>
bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8062536">https://bugs.openjdk.java.net/browse/JDK-8062536</a>
<br>
fix: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8062536/webrev.00/">http://cr.openjdk.java.net/~eistepan/8062536/webrev.00/</a>
<br>
<br>
Problem: Some tests explicitly set GC and fail
when another GC is set <br>
outside <br>
</blockquote>
<br>
I don't see why you have done this for the <br>
<br>
test/sun/tools/jps/TestJps*.java <br>
<br>
tests. They don't set any GC flags. <br>
<br>
<blockquote type="cite">Solution: Such tests
marked with the jtreg tag "requires" to skip
test <br>
if there is a conflict <br>
</blockquote>
<br>
Just wondering: Does a skipped test get a .jtr
file showing it was skipped; or does it only
appear in the higher-level jtreg log? <br>
<br>
Thanks, <br>
David <br>
<br>
<blockquote type="cite">Tested locally with
different GC flags (-XX:+UseG1GC, <br>
-XX:+UseParallelGC, -XX:+UseSerialGC,
-XX:+UseConcMarkSweep and without <br>
any GC flag). Tests are being excluded as
expected. No tests failed <br>
because of the conflict. <br>
<br>
Thanks, <br>
Evgeniya Stepanova <br>
<br>
// <br>
</blockquote>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<i>Evgeniya Stepanova</i></div>
</blockquote>
<br>
<br>
</div>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<i>Evgeniya Stepanova</i></div>
</blockquote>
<br>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<i>Evgeniya Stepanova</i></div>
</blockquote>
<br>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<i>Evgeniya Stepanova</i></div>
</body>
</html>