<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 2014-11-08 09:11, Dmitry Fazunenko
wrote:<br>
</div>
<blockquote cite="mid:545DD038.7030108@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Hi Mandy,<br>
<br>
<div class="moz-cite-prefix">On 08.11.2014 02:41, Mandy Chung
wrote:<br>
</div>
<blockquote cite="mid:545D58BE.3030404@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 11/7/14 3:34 AM, Evgeniya
Stepanova wrote:<br>
</div>
<blockquote cite="mid:545CAE30.9010708@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8062536/webrev.02/">http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/</a><br>
</blockquote>
<br>
What are the valid values of<span class="changed"> vm.gc? It's
a bit awk for null as a valid value and I would imagine "*"
wildcard may be a better value?<br>
</span></blockquote>
<br>
vm.gc variable is set by jtreg based on passed -XX:+Use???GC
command line vm flag.<br>
If such flag is not given vm.gc will be set to null (or "null"
which is same).<br>
<br>
So, vm.gc could be set to any value. In reality the following
strings are expected: null, "Parallel", "Serial", "G1",
"ConcMarkSweep".<br>
<br>
null means "not set", it doesn't mean "any".<br>
If a test is applicable for all GC - you don't need @requires
vm.gc == "*"<br>
</blockquote>
<br>
Note that the vm.gc abstraction is not really flexible enough for
our purposes. The way to specify a GC is constantly evolving and it
is not suitable to have this logic in the JTreg harness. I've filed
this bug about the issue:<br>
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/CODETOOLS-7901091">https://bugs.openjdk.java.net/browse/CODETOOLS-7901091</a><br>
<br>
Bengt<br>
<br>
<blockquote cite="mid:545DD038.7030108@oracle.com" type="cite"> <br>
<blockquote cite="mid:545D58BE.3030404@oracle.com" type="cite"><span
class="changed"> <br>
Since you are touching test/java/lang/management/** tests, we
can remove these shell tests and add multiple @run in the java
test instead. It'd be great if you can take this opportunity
to remove these shell tests as they are not really necessary.<br>
</span></blockquote>
<br>
Yes, agree, shell is not necessary here. But such refactoring is
better to be done as part of another RFE.<br>
<br>
Thanks,<br>
Dima<br>
<br>
<br>
<blockquote cite="mid:545D58BE.3030404@oracle.com" type="cite"><span
class="changed"> <br>
thanks<br>
Mandy<br>
</span> </blockquote>
<br>
</blockquote>
<br>
</body>
</html>