<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Hi Evgeniya,<br>
<br>
<div class="moz-cite-prefix">On 2014-11-24 14:13, Evgeniya Stepanova
wrote:<br>
</div>
<blockquote cite="mid:54732F0A.3020806@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
Hi,<br>
<div class="moz-forward-container"> <br>
Could you please review changes for 8065749 ?<br>
Test TestG1HeapRegionSize.java is G1-specific and could not work
without -XX:+UseG1GC passed directly.<br>
Option added to the run.<br>
bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8065749">https://bugs.openjdk.java.net/browse/JDK-8065749</a><br>
fix: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8065749/webrev.00/">http://cr.openjdk.java.net/~eistepan/8065749/webrev.00/</a><br>
</div>
</blockquote>
<br>
I think your suggested fix will work, but I have a question
regarding the original change.<br>
<br>
Before the original change the test explicitly checked that it was
run with G1 and just skipped otherwise:<br>
<br>
<a class="moz-txt-link-freetext" href="http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/comparison/6464714dd742/test/gc/arguments/TestG1HeapRegionSize.java">http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/comparison/6464714dd742/test/gc/arguments/TestG1HeapRegionSize.java</a><br>
<br>
Was this test really failing at all? I thought we were only going to
add @requires to tests that were failing due to conflicting GC
combinations. If it was working before I think a different approach
to fix the current problem would be to revert back to the old code
without @requires.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<blockquote cite="mid:54732F0A.3020806@oracle.com" type="cite">
<div class="moz-forward-container"> <br>
Thanks,<br>
Evgeniya Stepanova<br>
<br>
-- <br>
<div class="moz-signature"> <i>Evgeniya Stepanova</i></div>
<br>
</div>
<br>
</blockquote>
<br>
</body>
</html>