<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Gerard found a few portability bugs.
3rd request's the charm.<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edrwhite/8066821/webrev.02/">http://cr.openjdk.java.net/~drwhite/8066821/webrev.02</a><br>
<br>
Reran jprt and jtreg.<br>
<br>
- Derek<br>
<br>
On 1/12/15 5:10 PM, Derek White wrote:<br>
</div>
<blockquote cite="mid:54B44661.8070007@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edrwhite/8066821/webrev.00/">http://cr.openjdk.java.net/~drwhite/8066821/webrev.00/</a><br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8066821">https://bugs.openjdk.java.net/browse/JDK-8066821</a><br>
<br>
This webrev adds support for handling "<i>deprecated</i>" -XX
options (options that still <b>do</b> something but are planned
for removal) and "<i>alias</i>" options (alternate names for other
-XX options) by simply adding entries to the deprecated_jvm_flags
and/or aliased_jvm_flags tables. This follows the<br>
example of the existing obsolete_jvm_flags table.<br>
<br>
This replaces a lot of ad-hoc and occasionally wrong code in
arguments.cpp (including Arguments::check_deprecated_gc_flags) as
well as supporting automatically disabling options after a certain
version.<br>
<br>
Removed Code:<br>
- Removed global DefaultMaxRAMFraction, which was an "improper"
alias for "MaxRAMFraction" (two variables that were roughly kept
in sync vs. two names for the same variable).<br>
- Arguments::check_deprecated_gc_flags().<br>
- Alias handling code in Arguments::parse_each_vm_init_arg().<br>
It also avoids future ad-hoc and occasionally wrong code as new
options get aliased and deprecated.<br>
<br>
Tests:<br>
Deprecated and alias options can be tested by adding entries to
tables in new tests:<br>
VMAliasOptions.java<br>
VMDeprecatedOptions.java<br>
<br>
The new tests subsume these existing tests:<br>
test/gc/startup_warnings/TestDefaultMaxRAMFraction.java<br>
test/gc/startup_warnings/TestNoParNew.java <br>
<br>
<br>
Tests run:<br>
jprt<br>
jtreg<br>
<br>
Thanks,<br>
<br>
- Derek<br>
</blockquote>
<br>
</body>
</html>