<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Put together another webrev with
changes listed below:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~drwhite/8066821/webrev.03/">http://cr.openjdk.java.net/~drwhite/8066821/webrev.03/</a><br>
<br>
jtreg and jprt run.<br>
<br>
- Derek<br>
<br>
On 1/21/15 10:05 AM, Oracle wrote:<br>
</div>
<blockquote
cite="mid:10AD3F97-FA0A-4A6B-B66D-921C14A61D3E@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<div>Thanks Gerard,<br>
<br>
</div>
<div><br>
On Jan 20, 2015, at 6:59 PM, Gerard Ziemski <<a
moz-do-not-send="true" href="mailto:gerard.ziemski@oracle.com">gerard.ziemski@oracle.com</a>>
wrote:<br>
<br>
</div>
<blockquote type="cite">
<div>
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<pre wrap="">hi Derek ,
Very, very nice code and thank you for taking the time to do a bit of code cleanup. I have just a few comments/suggestions below for the “arguments.cpp<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="file:#1Insteadof%7B">" file:
#1 Instead of
{ "</a>MaxGCMinorPauseMillis", JDK_Version::jdk(8), JDK_Version::jdk(SpecialFlag::_removal_unscheduled)},
how about this:
{ "MaxGCMinorPauseMillis", JDK_Version::jdk(8), JDK_Version::jdk(JDK_Version::unscheduled())},
and move "bool is_removal_scheduled() const” API to JDK_Version class? It seems to me that any API that has to do with JDK version number should live in JDK_Version class.
</pre>
</div>
</blockquote>
<div><br>
</div>
How about "JDK_Version::undefined()" instead? That seems more
generally useful and less option-specific<br>
<blockquote type="cite">
<div>
<pre wrap="">#2 Instead of
.
.
.
{ "CMSMarkStackSizeMax", JDK_Version::jdk(9), JDK_Version::jdk(10)},
{ "CMSMarkStackSize", JDK_Version::jdk(9), JDK_Version::jdk(10)},
.
.
.
how about going back to the nice formatting we used to have like:
.
.
.
{ "CMSMarkStackSizeMax”, JDK_Version::jdk(9), JDK_Version::jdk(10)},
{ "CMSMarkStackSize”, JDK_Version::jdk(9), JDK_Version::jdk(10)},
.
.
.
The formatted text seems so much nicer to read.
</pre>
</div>
</blockquote>
<div><br>
</div>
OK. I thought I did that. Must have gotten lost.<br>
</blockquote>
<br>
My IDE snuck in and "fixed" the formatting. Somehow I didn't notice!<br>
<br>
Thanks,<br>
<br>
- Derek<br>
<br>
</body>
</html>