
<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Hi,</div><div><br></div>Not an official review but it’s a simple patch that looks good.<div><br></div><div>Kind regards,</div><div>Kirk</div><div><br><div><div>On Feb 2, 2015, at 4:51 PM, Yasumasa Suenaga <<a href="mailto:yasuenag@gmail.com">yasuenag@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><p dir="ltr">Hi,</p><p dir="ltr">I need more reviewer.<br>

Could you review it?</p><p dir="ltr"><a href="http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/">http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/</a><br></p><p dir="ltr">Thanks,</p><p dir="ltr">Yasumasa</p>

<div class="gmail_quote">2015/01/28 17:24 "Staffan Larsen" <<a href="mailto:staffan.larsen@oracle.com">staffan.larsen@oracle.com</a>>:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks good!<br>

<br>

Thanks,<br>

/Staffan<br>

<br>

> On 28 jan 2015, at 05:48, Yasumasa Suenaga <<a href="mailto:yasuenag@gmail.com">yasuenag@gmail.com</a>> wrote:<br>

><br>

> Hi Staffan, Kirk,<br>

><br>

> I agree to set "Diagnostic Command" to GCCause.<br>

> So I applied it to new patch.<br>

><br>

> <a href="http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/" target="_blank">http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/</a><br>

><br>

> Could you review it again?<br>

><br>

><br>

> Thanks,<br>

><br>

> Yasumasa<br>

><br>

><br>

> On 2015/01/28 5:06, Kirk Pepperdine wrote:<br>

>> Hi Staffan,<br>

>><br>

>>>><br>

>>>> Anyway, it’s a record in a GC log so I don’t see the value of GC.run. Certainly “DiagCmd" or even "Diagnostic Command” seems sufficient given the context.<br>

>>><br>

>>> Let’s go with “Diagnostic Command”, then.<br>

>><br>

>> Thank you!<br>

>><br>

>> Regards,<br>

>> Kirk<br>

>><br>

<br>

</blockquote></div>

</blockquote></div><br></div></body></html>