<div dir="ltr">Looks good. -Tao (tamao)</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 2, 2015 at 7:51 AM, Yasumasa Suenaga <span dir="ltr"><<a href="mailto:yasuenag@gmail.com" target="_blank">yasuenag@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Hi,</p>
<p dir="ltr">I need more reviewer.<br>
Could you review it?</p>
<p dir="ltr"><a href="http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/" target="_blank">http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/</a><br></p>
<p dir="ltr">Thanks,</p>
<p dir="ltr">Yasumasa</p>
<div class="gmail_quote">2015/01/28 17:24 "Staffan Larsen" <<a href="mailto:staffan.larsen@oracle.com" target="_blank">staffan.larsen@oracle.com</a>>:<div><div class="h5"><br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks good!<br>
<br>
Thanks,<br>
/Staffan<br>
<br>
> On 28 jan 2015, at 05:48, Yasumasa Suenaga <<a href="mailto:yasuenag@gmail.com" target="_blank">yasuenag@gmail.com</a>> wrote:<br>
><br>
> Hi Staffan, Kirk,<br>
><br>
> I agree to set "Diagnostic Command" to GCCause.<br>
> So I applied it to new patch.<br>
><br>
> <a href="http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/" target="_blank">http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/</a><br>
><br>
> Could you review it again?<br>
><br>
><br>
> Thanks,<br>
><br>
> Yasumasa<br>
><br>
><br>
> On 2015/01/28 5:06, Kirk Pepperdine wrote:<br>
>> Hi Staffan,<br>
>><br>
>>>><br>
>>>> Anyway, it’s a record in a GC log so I don’t see the value of GC.run. Certainly “DiagCmd" or even "Diagnostic Command” seems sufficient given the context.<br>
>>><br>
>>> Let’s go with “Diagnostic Command”, then.<br>
>><br>
>> Thank you!<br>
>><br>
>> Regards,<br>
>> Kirk<br>
>><br>
<br>
</blockquote></div></div></div>
</blockquote></div><br></div>