<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Okay, I'll wait and take a look at
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<span style="color: rgb(0, 0, 0); font-family: 'DejaVu Sans',
'Bitstream Vera Sans', 'Luxi Sans', Verdana, Arial, Helvetica;
font-size: 13.3333330154419px; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal;
line-height: 18.6666660308838px; orphans: auto; text-align:
left; text-indent: 0px; text-transform: none; white-space:
normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; display: inline !important;
float: none;"></span><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8069016">https://bugs.openjdk.java.net/browse/JDK-8069016</a>
<br>
<br>
joe<br>
<br>
On 02/06/2015 03:38 PM, Kim Barrett wrote:<br>
</div>
<blockquote
cite="mid:74B9CE55-AE03-4529-AA24-DF290D8D8DDC@oracle.com"
type="cite">
<pre wrap="">On Feb 5, 2015, at 6:51 PM, Joseph Provino <a class="moz-txt-link-rfc2396E" href="mailto:joseph.provino@oracle.com"><joseph.provino@oracle.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Please review these changes:
webrev is here: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jprovino/8067891/webrev.00/">http://cr.openjdk.java.net/~jprovino/8067891/webrev.00/</a>
</pre>
</blockquote>
<pre wrap="">
Not a review, but rather a "please wait" request.
src/cpu/ppc/vm/macroAssembler_ppc.cpp
2313 G1SATBCardTableModRefBS* bs = (G1SATBCardTableModRefBS*) Universe::heap()->barrier_set();
2314 assert(bs->kind() == BarrierSet::G1SATBCTLogging, "wrong barrier");
Pre-existing bug:
The assertion after the cast is wrong; if the barrier set is not of
the indicated type, the preceding cast has already invoked undefined
behavior. There are more of these.
I would *really* like to deal with
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8069016">https://bugs.openjdk.java.net/browse/JDK-8069016</a> first, before having
BarrierSet::G1SATBCT addressed. I have a fix that works, but need a
little time to tidy it up and then get it reviewed. I've been
distracted by other things recently, but hoped to get this out for
review in the next couple of days.
Unfortunately, I forgot to make JDK-8069016 a blocker for JDK-8067891.
</pre>
</blockquote>
<br>
</body>
</html>