<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 2015-02-13 22:11, Sangheon Kim
wrote:<br>
</div>
<blockquote cite="mid:54DE6890.5050704@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
Hi All,<br>
<br>
Sorry for sending many emails for this simple fix.<br>
After some discussion with StefanK, I decided to add a macro for
this assert.<br>
<br>
Webrev:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Esangheki/8073115/webrev.01/">http://cr.openjdk.java.net/~sangheki/8073115/webrev.01/</a><br>
</blockquote>
<br>
Looks good.<br>
<br>
Thanks for adding the macro.<br>
StefanK<br>
<blockquote cite="mid:54DE6890.5050704@oracle.com" type="cite"> <br>
Thanks,<br>
Sangheon<br>
<br>
<div class="moz-cite-prefix">On 02/13/2015 09:41 AM, Sangheon Kim
wrote:<br>
</div>
<blockquote cite="mid:54DE3754.6040409@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
Hi StefanK,<br>
<br>
Thanks for reviewing this and please see inline.<br>
<br>
On 02/13/2015 01:07 AM, Stefan Karlsson wrote:<br>
<blockquote cite="mid:54DDBEB4.2000909@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
Hi Sangheon,<br>
<br>
<div class="moz-cite-prefix">On 2015-02-13 07:54, Sangheon Kim
wrote:<br>
</div>
<blockquote cite="mid:54DD9FA0.2000107@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
<pre wrap="">Hi All,
Please review this small enhancement for better error messages when assert fails.
This change would be helpful for <a moz-do-not-send="true" id="key-val" rel="4766142" href="https://bugs.openjdk.java.net/browse/JDK-8071930">JDK-8071930</a> which is hard to reproduce.
I will need a sponsor for this change.
CR:
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8073115">https://bugs.openjdk.java.net/browse/JDK-8073115</a>
Webrev:
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Esangheki/8073115/webrev.00/">http://cr.openjdk.java.net/~sangheki/8073115/webrev.00/</a></pre>
</blockquote>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Esangheki/8073115/webrev.00/src/share/vm/gc_implementation/parallelScavenge/objectStartArray.hpp.udiff.html">http://cr.openjdk.java.net/~sangheki/8073115/webrev.00/src/share/vm/gc_implementation/parallelScavenge/objectStartArray.hpp.udiff.html</a><br>
<br>
You are duplicating the same assert three times. Could you
create a new define, say #define
assert_covered_region_contains(addr) ..., and remove the
duplication? This will also have the benefit of lowering the
line noise in the functions you change.<br>
</blockquote>
Basically I agree with you.<br>
But in this case I think the benefit of macro is limited to
reduce 3 lines than current proposal.<br>
Unless this macro moves to general header file, its usage would
be limited.<br>
So let me skip adding a new macro at this time.<br>
<br>
Thanks,<br>
Sangheon<br>
<br>
<blockquote cite="mid:54DDBEB4.2000909@oracle.com" type="cite">
<br>
Thanks,<br>
StefanK<br>
<br>
<blockquote cite="mid:54DD9FA0.2000107@oracle.com" type="cite">
<pre wrap="">Testing:
JPRT
Thanks,
Sangheon
</pre>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>