<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<div class="moz-cite-prefix">On 2/16/15 8:33 AM, Lindenmaier, Goetz
wrote:<br>
</div>
<blockquote
cite="mid:4295855A5C1DE049A61835A1887419CC2CF95ACA@DEWDFEMB12A.global.corp.sap"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 14 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;
mso-fareast-language:EN-US;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;
mso-fareast-language:EN-US;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Consolas","serif";
color:black;}
span.new
{mso-style-name:new;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;
mso-fareast-language:EN-US;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">Hi
Jon,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">thanks
for looking at this change!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">It’s
not that easy as just aligning to vm_page_size, but I can
use<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">CollectorPolicy::compute_heap_alignment():<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Egoetz/webrevs/8071822-jtregColPol/webrev.02/">http://cr.openjdk.java.net/~goetz/webrevs/8071822-jtregColPol/webrev.02/</a></span></p>
</div>
</blockquote>
<br>
Please revert to the original order of these lines unless it <br>
makes a difference.<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<pre> 990 set_basic_flag_values();
<span class="new"> 991 flag_value = 30 * M;</span></pre>
<br>
Could you define a variable to hold the heap alignment?<br>
<br>
size_t heap_alignment = <span class="changed">CollectorPolicy::compute_heap_alignment()<br>
<br>
just to make it a little more readable.<br>
<br>
Should the 30*M be aligned? <br>
<br>
What is the 20*m? Could you assign it to a variable with a
descriptive<br>
name?<br>
<br>
Jon<br>
</span>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<blockquote
cite="mid:4295855A5C1DE049A61835A1887419CC2CF95ACA@DEWDFEMB12A.global.corp.sap"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">Best
regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">
Goetz.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:DE"
lang="EN-US">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:DE"
lang="EN-US"> hotspot-gc-dev
[<a class="moz-txt-link-freetext" href="mailto:hotspot-gc-dev-bounces@openjdk.java.net">mailto:hotspot-gc-dev-bounces@openjdk.java.net</a>] <b>On
Behalf Of </b>
Jon Masamitsu<br>
<b>Sent:</b> Donnerstag, 12. Februar 2015 00:35<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: RFR(S): 8071822: [TEST_BUG] Adapt
collectorPolicy internal tests to support 64K pages<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Goetz,<br>
<br>
Could you have used page alignment to determine the<br>
new expected sizes?<br>
<br>
For example, instead of <o:p></o:p></p>
<pre><span class="new"> 987 // Calculate what we expect the flag to be.</span><o:p></o:p></pre>
<pre><span class="new"> 988 flag_value = adapted_InitialHeapSize - MaxNewSize;<o:p></o:p></span></pre>
<pre> 989 verify_old_initial(flag_value);<o:p></o:p></pre>
<p class="MsoNormal">expected_old_initial =
align_size_up(flag_value, os::vm_page_size())<br>
verify_old_initial(expected_old_initial)<br>
<br>
Jon<o:p></o:p></p>
<div>
<p class="MsoNormal">On 2/10/2015 7:43 AM, Lindenmaier, Goetz
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="color:#1F497D">Hi,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">could
someone please have a look at this change?</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">It’s
really not that big.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">GC-folks
maybe?</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">Thanks,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">
Goetz.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:DE"
lang="EN-US">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:DE"
lang="EN-US"> Lindenmaier, Goetz <br>
<b>Sent:</b> Freitag, 30. Januar 2015 10:36<br>
<b>To:</b> hotspot-dev Source Developers<br>
<b>Subject:</b> RFR(S): 8071822: [TEST_BUG] Adapt
collectorPolicy internal tests to support 64K pages</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hi,</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">this fixes a final
problem with 64-bit page size in the jtreg tests.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">It addresses the
internal VM tests of the collector policies.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Those tests set a row
of fixed flag values, and one special value to test.
</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Then they call the
heap ergonomics and check the expected result of the</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">special value. <br>
<br>
With 64K page size, the heap ergonomics adapt more values,
breaking the tests. </span>
<o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Wrt. the adapted flag
values the tests are correct though.
<br>
<br>
This change makes the expected values depend on the
adapted flags, and the </span>
<o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">tests pass. They only
depend on adapted flags that are not subject of the
</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">corresponding test. </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Please review this
test. I please need a sponsor.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Egoetz/webrevs/8071822-jtregColPol/webrev.01/src/share/vm/memory/collectorPolicy.cpp.udiff.html">http://cr.openjdk.java.net/~goetz/webrevs/8071822-jtregColPol/webrev.01/</a>
</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"><a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8071822">https://bugs.openjdk.java.net/browse/JDK-8071822</a></span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Best regards,</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> Goetz.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman","serif";mso-fareast-language:DE"><o:p> </o:p></span></p>
</div>
</blockquote>
<br>
</body>
</html>