<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;
mso-fareast-language:EN-US;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;
mso-fareast-language:EN-US;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;
mso-fareast-language:EN-US;}
span.new
{mso-style-name:new;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle24
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.changed
{mso-style-name:changed;}
span.EmailStyle26
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle27
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle28
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:70.85pt 70.85pt 56.7pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Thanks a lot!!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> Goetz.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:ZH-CN">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:ZH-CN">
Jon Masamitsu [mailto:jon.masamitsu@oracle.com] <br>
<b>Sent:</b> Friday, February 20, 2015 8:21 PM<br>
<b>To:</b> Lindenmaier, Goetz; 'hotspot-gc-dev@openjdk.java.net'; 'Dmitry Fazunenko'<br>
<b>Subject:</b> Re: RFR(S): 8071822: [TEST_BUG] Adapt collectorPolicy internal tests to support 64K pages<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 2/20/2015 9:28 AM, Lindenmaier, Goetz wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="color:#1F497D">Hi Jon and Dmitry,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks for looking at this!</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">renamed to over_size and removed ;m:</span>
<o:p></o:p></p>
<p class="MsoNormal"><a href="http://cr.openjdk.java.net/%7Egoetz/webrevs/8071822-jtregColPol/webrev.04/">http://cr.openjdk.java.net/~goetz/webrevs/8071822-jtregColPol/webrev.04/</a><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal">I please need a sponsor.<o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif";mso-fareast-language:ZH-CN"><br>
I'll sponsor.<br>
<br>
Jon<br>
<br>
<br>
<o:p></o:p></span></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Best regards,<o:p></o:p></p>
<p class="MsoNormal"> Goetz.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:ZH-CN">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:ZH-CN">
Jon Masamitsu [<a href="mailto:jon.masamitsu@oracle.com">mailto:jon.masamitsu@oracle.com</a>]
<br>
<b>Sent:</b> Friday, February 20, 2015 5:21 PM<br>
<b>To:</b> Lindenmaier, Goetz; <a href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: RFR(S): 8071822: [TEST_BUG] Adapt collectorPolicy internal tests to support 64K pages</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<div>
<p class="MsoNormal">On 2/18/2015 1:52 AM, Lindenmaier, Goetz wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="color:#1F497D">Hi Jon,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt">> Please revert to the original order of these lines
</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt">> Could you define a variable to hold the heap alignment?</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt">Done.</span><o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span style="font-size:12.0pt"><br>
Thanks.<br>
<br>
<br>
<br>
</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span class="changed"><span style="font-size:12.0pt">> Should the 30*M be aligned?
</span></span><span style="font-size:12.0pt"><br>
It works as is, so I didn’t want to change it. Also, OldSize is not aligned to heap_alignment.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt">It ends up being 10M, while heap_alignment is 32M on the machine with 64K pages.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt"><br>
Ok.<br>
<br>
<br>
<br>
</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span class="changed"><span style="font-size:12.0pt">> What is the 20*m? </span></span><o:p></o:p></p>
<p class="MsoNormal">The tests wants MaxNewSize + OldSize > MaxHeapSize, see comment. Before, the<o:p></o:p></p>
<p class="MsoNormal">flag_value was just chosen accordingly (170M). Now I add +20M to MaxNewSize<o:p></o:p></p>
<p class="MsoNormal">to assure this, as I have to compute MaxNewSize.<o:p></o:p></p>
<p class="MsoNormal">Is ‘overlap’ a good name?<o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:12.0pt"><br>
Would it be accurate to change overlay (doesn't seem quite) right to<br>
over_size and to change the comment to</span><o:p></o:p></p>
<pre><span class="new">989 // We intentionally set MaxNewSize + OldSize > MaxHeapSize <b><i>(see over_size)</i></b>.</span><o:p></o:p></pre>
<p class="MsoNormal"><span style="font-size:12.0pt"><br>
Either way (overlap or over_size) is acceptable so you can decide.<br>
Consider this reviewed. I don't want to delay you even longer than I<br>
have.<br>
<br>
Jon<br>
<br>
<br>
<br>
</span><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Here’s the new webrev:<o:p></o:p></p>
<p class="MsoNormal"><a href="http://cr.openjdk.java.net/%7Egoetz/webrevs/8071822-jtregColPol/webrev.03/">http://cr.openjdk.java.net/~goetz/webrevs/8071822-jtregColPol/webrev.03/</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Thanks and best regards,<o:p></o:p></p>
<p class="MsoNormal"> Goetz.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:DE">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:DE"> Jon
Masamitsu [<a href="mailto:jon.masamitsu@oracle.com">mailto:jon.masamitsu@oracle.com</a>]
<br>
<b>Sent:</b> Dienstag, 17. Februar 2015 19:57<br>
<b>To:</b> Lindenmaier, Goetz; <a href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: RFR(S): 8071822: [TEST_BUG] Adapt collectorPolicy internal tests to support 64K pages</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<div>
<p class="MsoNormal">On 2/16/15 8:33 AM, Lindenmaier, Goetz wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="color:#1F497D">Hi Jon,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">thanks for looking at this change!</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">It’s not that easy as just aligning to vm_page_size, but I can use</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">CollectorPolicy::compute_heap_alignment():</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"><a href="http://cr.openjdk.java.net/%7Egoetz/webrevs/8071822-jtregColPol/webrev.02/">http://cr.openjdk.java.net/~goetz/webrevs/8071822-jtregColPol/webrev.02/</a></span><o:p></o:p></p>
</blockquote>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:12.0pt"><br>
Please revert to the original order of these lines unless it <br>
makes a difference.</span><o:p></o:p></p>
<pre> 990 set_basic_flag_values();<o:p></o:p></pre>
<pre><span class="new"> 991 flag_value = 30 * M;</span><o:p></o:p></pre>
<p class="MsoNormal"><span style="font-size:12.0pt"><br>
Could you define a variable to hold the heap alignment?<br>
<br>
size_t heap_alignment = <span class="changed">CollectorPolicy::compute_heap_alignment()</span><br>
<br>
<span class="changed">just to make it a little more readable.</span><br>
<br>
<span class="changed">Should the 30*M be aligned? </span><br>
<br>
<span class="changed">What is the 20*m? Could you assign it to a variable with a descriptive</span><br>
<span class="changed">name?</span><br>
<br>
<span class="changed">Jon</span><br>
<br>
<br>
<br>
</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Best regards,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> Goetz.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:DE">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext;mso-fareast-language:DE"> hotspot-gc-dev
[<a href="mailto:hotspot-gc-dev-bounces@openjdk.java.net">mailto:hotspot-gc-dev-bounces@openjdk.java.net</a>]
<b>On Behalf Of </b>Jon Masamitsu<br>
<b>Sent:</b> Donnerstag, 12. Februar 2015 00:35<br>
<b>To:</b> <a href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: RFR(S): 8071822: [TEST_BUG] Adapt collectorPolicy internal tests to support 64K pages</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Goetz,<br>
<br>
Could you have used page alignment to determine the<br>
new expected sizes?<br>
<br>
For example, instead of <o:p></o:p></p>
<pre><span class="new"> 987 // Calculate what we expect the flag to be.</span><o:p></o:p></pre>
<pre><span class="new"> 988 flag_value = adapted_InitialHeapSize - MaxNewSize;</span><o:p></o:p></pre>
<pre> 989 verify_old_initial(flag_value);<o:p></o:p></pre>
<p class="MsoNormal">expected_old_initial = align_size_up(flag_value, os::vm_page_size())<br>
verify_old_initial(expected_old_initial)<br>
<br>
Jon<o:p></o:p></p>
<div>
<p class="MsoNormal">On 2/10/2015 7:43 AM, Lindenmaier, Goetz wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="color:#1F497D">Hi,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">could someone please have a look at this change?</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">It’s really not that big.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">GC-folks maybe?</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> Goetz.</span><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:DE">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:DE"> Lindenmaier, Goetz
<br>
<b>Sent:</b> Freitag, 30. Januar 2015 10:36<br>
<b>To:</b> hotspot-dev Source Developers<br>
<b>Subject:</b> RFR(S): 8071822: [TEST_BUG] Adapt collectorPolicy internal tests to support 64K pages</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">this fixes a final problem with 64-bit page size in the jtreg tests.<o:p></o:p></p>
<p class="MsoNormal">It addresses the internal VM tests of the collector policies.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Those tests set a row of fixed flag values, and one special value to test.
<o:p></o:p></p>
<p class="MsoNormal">Then they call the heap ergonomics and check the expected result of the<o:p></o:p></p>
<p class="MsoNormal">special value. <br>
<br>
With 64K page size, the heap ergonomics adapt more values, breaking the tests. <o:p>
</o:p></p>
<p class="MsoNormal">Wrt. the adapted flag values the tests are correct though. <br>
<br>
This change makes the expected values depend on the adapted flags, and the <o:p></o:p></p>
<p class="MsoNormal">tests pass. They only depend on adapted flags that are not subject of the
<o:p></o:p></p>
<p class="MsoNormal">corresponding test. <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Please review this test. I please need a sponsor.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><a href="http://cr.openjdk.java.net/%7Egoetz/webrevs/8071822-jtregColPol/webrev.01/src/share/vm/memory/collectorPolicy.cpp.udiff.html">http://cr.openjdk.java.net/~goetz/webrevs/8071822-jtregColPol/webrev.01/</a>
<o:p></o:p></p>
<p class="MsoNormal"><a href="https://bugs.openjdk.java.net/browse/JDK-8071822">https://bugs.openjdk.java.net/browse/JDK-8071822</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Best regards,<o:p></o:p></p>
<p class="MsoNormal"> Goetz.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif";mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
</div>
</body>
</html>