<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Axel,<br>
<br>
On 06/03/15 17:17, Siebenborn, Axel wrote:<br>
</div>
<blockquote
cite="mid:02D5D45C1F8DB848A7AE20E80EE61A5C398F8055@DEWDFEMB20C.global.corp.sap"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 14 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">can I have some reviews
for this small change.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">It fixes a serious
problem as the pointer _next_klass is changed concurrently
but not correctly declared as volatile.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">The change fixes the
declaration and removes an unneeded cast.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">bug:
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8074561">https://bugs.openjdk.java.net/browse/JDK-8074561</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~asiebenborn/8074561/webrev.00/">http://cr.openjdk.java.net/~asiebenborn/8074561/webrev.00/</a></span></p>
</div>
</blockquote>
<br>
Looks good. Thanks for finding and fixing this issue.<br>
<br>
BTW, there might be a few more problematic places in the GC code: <br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8033552">https://bugs.openjdk.java.net/browse/JDK-8033552</a> - Fix missing
missing volatile specifiers in CAS operations in GC code<br>
<br>
<blockquote
cite="mid:02D5D45C1F8DB848A7AE20E80EE61A5C398F8055@DEWDFEMB20C.global.corp.sap"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I need a sponsor for the
change.</span></p>
</div>
</blockquote>
<br>
I'll sponsor the change.<br>
<br>
Thanks,<br>
StefanK<br>
<br>
<blockquote
cite="mid:02D5D45C1F8DB848A7AE20E80EE61A5C398F8055@DEWDFEMB20C.global.corp.sap"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Axel<o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>