<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Hi David,<br>
      <br>
      On 27/03/15 09:52, David Lindholm wrote:<br>
    </div>
    <blockquote cite="mid:55151A38.7000903@oracle.com" type="cite">Hi,
      <br>
      <br>
      Please review this fix that removes the macro
      PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC in gc files and fixes the gcc
      warnings for the format strings. Some files had this macro even
      though there were no warnings in them.
      <br>
      <br>
      This patch deals with all the parallelScavenge source files that
      had this macro. There will be separate patches for the other
      collectors.
      <br>
      <br>
      Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~david/JDK-8076071/webrev.00/">http://cr.openjdk.java.net/~david/JDK-8076071/webrev.00/</a>
      <br>
    </blockquote>
    <br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~david/JDK-8076071/webrev.00/src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp.udiff.html">http://cr.openjdk.java.net/~david/JDK-8076071/webrev.00/src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp.udiff.html</a><br>
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
    <pre>
<meta http-equiv="content-type" content="text/html; charset=UTF-8"> 418     gclog_or_tty->print_cr("Current region: [" PTR_FORMAT ", " PTR_FORMAT ") "
 419       "New region: [" PTR_FORMAT ", " PTR_FORMAT ")",
<span class="changed"> 420       p2i(s1->bottom()), p2i(s1->end()),</span>
<span class="changed"> 421           p2i(s1MR.start()), p2i(s1MR.end()));</span><span class="new">


If you have to line break, could you align the parameters? Like:</span>

<span class="new"><meta http-equiv="content-type" content="text/html; charset=UTF-8"> 418     gclog_or_tty->print_cr("Current region: [" PTR_FORMAT ", " PTR_FORMAT ") "
 419       "New region: [" PTR_FORMAT ", " PTR_FORMAT ")",
<span class="changed"> 420       p2i(s1->bottom()), p2i(s1->end()),</span>
<span class="changed"> 421       p2i(s1MR.start()), p2i(s1MR.end()));

Thanks for fixing this!

StefanK
</span></span>
</pre>
    <blockquote cite="mid:55151A38.7000903@oracle.com" type="cite">Bug:
      <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8076071">https://bugs.openjdk.java.net/browse/JDK-8076071</a>
      <br>
      <br>
      Testing done: Passed JPRT
      <br>
      <br>
      <br>
      Thanks,
      <br>
      David
      <br>
    </blockquote>
    <br>
  </body>
</html>