<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Bengt,<br>
<br>
Thanks for the review.<br>
<br>
/David<br>
<br>
<div class="moz-cite-prefix">On 2015-03-27 12:40, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:551541CB.9020200@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">On 2015-03-27 11:01, Stefan Karlsson
wrote:<br>
</div>
<blockquote cite="mid:55152A84.6080704@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 27/03/15 10:50, David Lindholm
wrote:<br>
</div>
<blockquote cite="mid:551527FE.5040603@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Hi Stefan,<br>
<br>
I have fixed this. Do you need a new webrev?<br>
</blockquote>
<br>
No. I'm OK with the patch if you fix the alignment.<br>
</blockquote>
<br>
With the alignment fix this looks good to me too.<br>
<br>
Bengt<br>
<br>
<blockquote cite="mid:55152A84.6080704@oracle.com" type="cite"> <br>
Thanks,<br>
StefanK<br>
<blockquote cite="mid:551527FE.5040603@oracle.com" type="cite">
<br>
<br>
Thanks,<br>
David<br>
<br>
<div class="moz-cite-prefix">On 2015-03-27 10:28, Stefan
Karlsson wrote:<br>
</div>
<blockquote cite="mid:551522AC.9010402@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 27/03/15 10:04, David
Lindholm wrote:<br>
</div>
<blockquote cite="mid:55151D39.6020401@oracle.com"
type="cite">Hi, <br>
<br>
Please review this fix that removes the macro
PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC in gc files and fixes
the gcc warnings for the format strings. Some files had
this macro even though there were no warnings in them. <br>
<br>
This patch deals with all the parNew source files that had
this macro. <br>
<br>
Webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edavid/JDK-8076072/webrev.00/">http://cr.openjdk.java.net/~david/JDK-8076072/webrev.00/</a>
<br>
</blockquote>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edavid/JDK-8076072/webrev.00/src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp.frames.html">http://cr.openjdk.java.net/~david/JDK-8076072/webrev.00/src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp.frames.html</a><br>
<br>
The alignment needs to be fixed:<br>
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<pre> 380 assert(sp->used_region().end() > used.end(),
381 err_msg("Expansion did not happen: "
382 "[" PTR_FORMAT "," PTR_FORMAT ") -> [" PTR_FORMAT "," PTR_FORMAT ")",
<span class="changed"> 383 p2i(sp->used_region().start()), p2i(sp->used_region().end()),</span>
<span class="changed"> 384 p2i(used.start()), p2i(used.end())));
Thanks,
StefanK
</span></pre>
<br>
<blockquote cite="mid:55151D39.6020401@oracle.com"
type="cite">Bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8076072">https://bugs.openjdk.java.net/browse/JDK-8076072</a>
<br>
<br>
Testing done: Passed JPRT <br>
<br>
<br>
Thanks, <br>
David <br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>